-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow leading whitespace in input parameters #965
Conversation
…rthenon into brryan/param_whitespace_sanitize
BTW I tested this by adding a leading space character to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How about also adding the one-line test you mention (adding a space to one of the examples input files called by the test suite)?
Good idea @pgrete, done (I changed |
PR Summary
Currently, input parameters are read incorrectly. For example,
will read
var
as= 1.0
, which when called withGetReal
will cast to0
.This PR fixes a bug where the length of the name was incorrectly calculated if leading whitespace was present in the input parameter file.
PR Checklist