Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move creation of SparsePackCache identifier string #944

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

jdolence
Copy link
Collaborator

@jdolence jdolence commented Sep 28, 2023

PR Summary

This is a tiny PR that just moves the creation of the string identifier for sparse packs into the descriptor. While descriptors can almost always be made static variables (so they only get built once), the packs themselves cannot. Moving the creation of the identifier string to the descriptor means we often only have to build the string once.

It's not a huge improvement, but believe it or not you can actually see a reliable boost in performance from this in our downstream code.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@jdolence
Copy link
Collaborator Author

@pdmullen @Yurlungur @bprather

this is super short. quick approval?

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement 👍

@jdolence jdolence merged commit 4f153d4 into develop Sep 28, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants