Move creation of SparsePackCache identifier string #944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a tiny PR that just moves the creation of the string identifier for sparse packs into the descriptor. While descriptors can almost always be made static variables (so they only get built once), the packs themselves cannot. Moving the creation of the identifier string to the descriptor means we often only have to build the string once.
It's not a huge improvement, but believe it or not you can actually see a reliable boost in performance from this in our downstream code.
PR Checklist