Skip to content

Internal refinement op registration #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2023
Merged

Internal refinement op registration #926

merged 2 commits into from
Aug 22, 2023

Conversation

bprather
Copy link
Collaborator

PR Summary

Trivial PR to thread new internal op out to user code.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@bprather bprather changed the title Refinement op registration Internal refinement op registration Aug 21, 2023
@bprather bprather requested review from lroberts36 and jonahm-LANL and removed request for lroberts36 August 21, 2023 15:58
Yurlungur
Yurlungur approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. yeah this was missing

lroberts36
lroberts36 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that fix.

@bprather bprather enabled auto-merge August 22, 2023 21:41
@bprather bprather merged commit 0e8bc29 into develop Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@lroberts36 lroberts36 lroberts36 approved these changes

@jonahm-LANL jonahm-LANL Awaiting requested review from jonahm-LANL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bprather @Yurlungur @lroberts36