-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kokkos integration (and switch to default serial
on host)
#896
Conversation
serial
on host)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Love to see a negative line count PR. Doesn't this also resolve #895? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments appended.
message(WARNING | ||
"Intel optimizer flags may not be passed through NVCC wrapper correctly. " | ||
"If you encounter problems, please delete your CMake cache " | ||
"and rerun CMake with -DTEST_INTEL_OPTIMIZATION=OFF.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an issue with the new LLVM-based Intel, or the old Intel compiler, or both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
If it's up to me I'd even remove these this and, if people actually use it, let them move it to a machine specific config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that would be cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any strong feelings here by anyone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really.
Indeed, it does. Linking. |
Can we go ahead and merge? (I just briefly enabled and disabled auto-merge to trigger the full pipeline for testing) |
PR Summary
PARTHENON_DISABLE_OPENMP
option (and default to serial for host parallel). OpenMP can be enabled byKokkos_ENABLE_OPENMP
Fixes #871
Fixes #897
Fixes #895
PR Checklist