-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to Kokkos 4.0.1 #888
Conversation
The HIP tests are failing because we need ROCm >= 5.2 for Kokkos 4:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change anything in the cmake? Or is it enough to update the submodule? Are the ROCM dependencies modern enough we can rely on them?
I was hoping @pgrete might answer these questions based on building on Frontier :) |
It looks like we need a newer ROCm container image:
|
@pgrete @Yurlungur would it make sense to use a "standard" ROCm container, such as this one provided by AMD for ROCm 5.3: https://github.com/RadeonOpenCompute/ROCm-docker/blob/master/rocm-terminal/Dockerfile |
I defer to @pgrete on this one |
I'll take care of an image update (when I'm actually back at my desk tomorrow after 2.5 weeks of conferences/workshops) |
I updated the other infrastructure related pieces. |
Now I am confused. Looks like our compiler checks not mandatory to pass in order to trigger auto-merge. |
PR Summary
Upgrades the built-in Kokkos submodule to Kokkos 4. This is needed for Frontier, Chicoma, possibly other machines.
Closes #842.
PR Checklist