Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Kokkos 4.0.1 #888

Merged
merged 4 commits into from
Jun 21, 2023
Merged

update to Kokkos 4.0.1 #888

merged 4 commits into from
Jun 21, 2023

Conversation

BenWibking
Copy link
Collaborator

PR Summary

Upgrades the built-in Kokkos submodule to Kokkos 4. This is needed for Frontier, Chicoma, possibly other machines.

Closes #842.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@BenWibking
Copy link
Collaborator Author

The HIP tests are failing because we need ROCm >= 5.2 for Kokkos 4:

CMake Error at external/Kokkos/cmake/kokkos_compiler_id.cmake:194 (MESSAGE):
  Compiler not supported by Kokkos.  Required compiler versions:

      Clang(CPU)         8.0.0 or higher
      Clang(CUDA)       10.0.0 or higher
      GCC                8.2.0 or higher
      Intel             19.0.5 or higher
      IntelLLVM(CPU)  2021.1.1 or higher
      IntelLLVM(SYCL) 2022.0.0 or higher
      NVCC              11.0.0 or higher
      HIPCC              5.2.0 or higher
      NVHPC/PGI           22.3 or higher
      MSVC               19.29 or higher
      XL/XLClang           not supported

  Compiler: HIPCC 4.4.21401

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change anything in the cmake? Or is it enough to update the submodule? Are the ROCM dependencies modern enough we can rely on them?

@BenWibking
Copy link
Collaborator Author

Do we need to change anything in the cmake? Or is it enough to update the submodule? Are the ROCM dependencies modern enough we can rely on them?

I was hoping @pgrete might answer these questions based on building on Frontier :)

@BenWibking
Copy link
Collaborator Author

It looks like we need a newer ROCm container image:

image: registry.gitlab.com/pgrete/parthenon/rocm4.5-mpi-hdf5

@BenWibking
Copy link
Collaborator Author

It looks like we need a newer ROCm container image:

image: registry.gitlab.com/pgrete/parthenon/rocm4.5-mpi-hdf5

@pgrete @Yurlungur would it make sense to use a "standard" ROCm container, such as this one provided by AMD for ROCm 5.3: https://github.com/RadeonOpenCompute/ROCm-docker/blob/master/rocm-terminal/Dockerfile

@Yurlungur
Copy link
Collaborator

I defer to @pgrete on this one

@pgrete
Copy link
Collaborator

pgrete commented Jun 14, 2023

I'll take care of an image update (when I'm actually back at my desk tomorrow after 2.5 weeks of conferences/workshops)

@pgrete
Copy link
Collaborator

pgrete commented Jun 21, 2023

I updated the other infrastructure related pieces.

@pgrete pgrete enabled auto-merge (squash) June 21, 2023 08:00
@pgrete pgrete merged commit 3596f29 into develop Jun 21, 2023
@pgrete
Copy link
Collaborator

pgrete commented Jun 21, 2023

Now I am confused. Looks like our compiler checks not mandatory to pass in order to trigger auto-merge.
I'll fix this in a follow up PR and we can ignore this for now.

@pgrete pgrete deleted the kokkos-4 branch June 21, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kokkos 4.0.0 / CUDA 12 support?
3 participants