Add Crusher/Frontier machine file and bump Kokkos to 3.7.01 #805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
All tests on Crusher now pass (both serial [requires serial HDF5 lib] and with MPI).
With older versions of Kokkos (e.g., the our current 3.6) some test still fail, which is why I bumped the Kokkos version.
I also tried to check the Kokkos version but didn't succeed (without adding more cmake boilerplate) as we add the Kokkos source directly (and thus don't get access the "Kokkos package version").
From my point of view, this is not an issue (or warrants additional code only to add this check) as our primary use case is the submodule anyway.
Also in prep for the bump to the Kokkos 4.0 release (which is scheduled for this month and removes HIP from "experimental" stage), I also deactivated the Kokkos 3 deprecated code (which we never used anyway).
I also requested more reviewers than necessary to trigger/encourage downstream testing.
PR Checklist