Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crusher/Frontier machine file and bump Kokkos to 3.7.01 #805

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

pgrete
Copy link
Collaborator

@pgrete pgrete commented Dec 23, 2022

PR Summary

All tests on Crusher now pass (both serial [requires serial HDF5 lib] and with MPI).
With older versions of Kokkos (e.g., the our current 3.6) some test still fail, which is why I bumped the Kokkos version.
I also tried to check the Kokkos version but didn't succeed (without adding more cmake boilerplate) as we add the Kokkos source directly (and thus don't get access the "Kokkos package version").
From my point of view, this is not an issue (or warrants additional code only to add this check) as our primary use case is the submodule anyway.
Also in prep for the bump to the Kokkos 4.0 release (which is scheduled for this month and removes HIP from "experimental" stage), I also deactivated the Kokkos 3 deprecated code (which we never used anyway).

I also requested more reviewers than necessary to trigger/encourage downstream testing.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • (@lanl.gov employees) Update copyright on changed files

@pgrete pgrete enabled auto-merge (squash) January 13, 2023 16:06
@pgrete pgrete disabled auto-merge January 16, 2023 15:28
@pgrete pgrete enabled auto-merge (squash) January 16, 2023 15:28
@pgrete pgrete merged commit db885f3 into develop Jan 16, 2023
@pgrete pgrete deleted the pgrete/crusher-frontier-machine branch January 16, 2023 15:58
@pgrete pgrete linked an issue Jan 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression test fail on Spock/Crusher/Frontier/HIP
3 participants