-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New action: check PR dependencies & warn until requirements merged #777
Conversation
@bprather can you try re-triggering the CI on this, maybe by making a quick change or something? I believe I have fixed the permissions issue. |
Check failed successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Can you update the changelog? Then if we can remove the dependency, we should get another approval and merge this bad boy in. :)
Pinging @lroberts36 @pgrete for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems like it is working!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops didn't realize I hadn't approved. LGTM. 👍
Add a Github action which checks dependencies between PRs. Should fail until all required PRs are merged.
Action repository is here: https://github.com/gregsdennis/dependencies-action
The required access token need cover only reading pull requests and issues, which are public anyway. It keys on any dependencies mentioned in the opening comment, e.g.
Depends on #772