Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New action: check PR dependencies & warn until requirements merged #777

Merged
merged 5 commits into from
Nov 3, 2022

Conversation

bprather
Copy link
Collaborator

@bprather bprather commented Nov 1, 2022

Add a Github action which checks dependencies between PRs. Should fail until all required PRs are merged.

Action repository is here: https://github.com/gregsdennis/dependencies-action

The required access token need cover only reading pull requests and issues, which are public anyway. It keys on any dependencies mentioned in the opening comment, e.g.

Depends on #772

Ben Prather added 2 commits November 1, 2022 13:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bprather bprather mentioned this pull request Nov 1, 2022
@Yurlungur
Copy link
Collaborator

@bprather can you try re-triggering the CI on this, maybe by making a quick change or something? I believe I have fixed the permissions issue.

@bprather
Copy link
Collaborator Author

bprather commented Nov 1, 2022

Check failed successfully.

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Can you update the changelog? Then if we can remove the dependency, we should get another approval and merge this bad boy in. :)

@Yurlungur
Copy link
Collaborator

Pinging @lroberts36 @pgrete for review

Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like it is working!

@bprather bprather mentioned this pull request Nov 3, 2022
7 tasks
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops didn't realize I hadn't approved. LGTM. 👍

@Yurlungur Yurlungur merged commit d839a8d into develop Nov 3, 2022
@Yurlungur Yurlungur deleted the bprather/pr-dependencies branch November 3, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants