Move default loop policy to meshblock. Closes #68 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
requested changes
Aug 5, 2020
src/reconstruct/dc_inline.hpp
Outdated
| @@ -39,7 +39,8 @@ void DonorCellX1(parthenon::team_mbr_t const &member, const int k, const int j, | |||
| // compute L/R states for each variable | |||
| for (int n = 0; n <= nu; ++n) { | |||
| parthenon::par_for_inner( | |||
| member, il, iu, [&](const int i) { ql(n, i + 1) = qr(n, i) = q(n, k, j, i); }); | |||
| DEFAULT_INNER_LOOP_PATTERN, member, il, iu, | |||
AndrewGaspar
approved these changes
Aug 11, 2020
Codecov Report
@@ Coverage Diff @@
## develop #252 +/- ##
===========================================
- Coverage 56.63% 56.60% -0.03%
===========================================
Files 97 97
Lines 10504 10493 -11
===========================================
- Hits 5949 5940 -9
+ Misses 4555 4553 -2
Continue to review full report at Codecov.
|
|
@Yurlungur I tried to address all your comments. This should be ready for re-review now. |
Yurlungur
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR cleans up the default wrapper choices effectively removing one level in the nested hierarchy as the default pattern is now set at the
MeshBlocklevel.Moreover, the default pattern is now set by CMake rather than
ifdefsin the header.That the intermediate (now removed) wrappers were not actively used can also be seen by effectively only unit tests being affected by this change.
Already previously, the usage of
pmb->par_forwas encouraged as this is ensures that we use the correct execution space.PR Checklist