Skip to content

[Bugfix]: Propagate flux Metadata correctly in SparsePool #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pgrete merged 3 commits into from
May 16, 2025
Merged

[Bugfix]: Propagate flux Metadata correctly in SparsePool #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86c9288
propagate flux metadata correctly in SparsePool
lroberts36 Apr 30, 2025
1d42d30
changelog
lroberts36 Apr 30, 2025
b27f408
Merge branch 'develop' into lroberts36/bugfix-flux-metadata
pgrete May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
- [[PR 1172]](https://github.com/parthenon-hpc-lab/parthenon/pull/1172) Make parthenon manager robust against external MPI init and finalize calls

### Fixed (not changing behavior/API/variables/...)
- [[PR 1249]](https://github.com/parthenon-hpc-lab/parthenon/pull/1249) Fix flux metadata propagation in sparse pools
- [[PR 1241]](https://github.com/parthenon-hpc-lab/parthenon/pull/1241) Emit an error message when using uninitialized multigrid blocks
- [[PR 1248]](https://github.com/parthenon-hpc-lab/parthenon/pull/1248) Fix edge case regarding AMR de-refinement logic
- [[PR 1240]](https://github.com/parthenon-hpc-lab/parthenon/pull/1240) Fix I/O for CellMemAligned variables
Expand Down
7 changes: 5 additions & 2 deletions src/interface/sparse_pool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,13 @@ MakeSparseVarMetadataImpl(Metadata *in, const std::vector<int> &shape,
const MetadataFlag *vector_tensor,
const std::vector<std::string> &component_labels) {
// copy shared metadata
auto flx_metadata = in->IsSet(Metadata::WithFluxes) ? in->GetSPtrFluxMetadata()
: std::make_shared<Metadata>();
auto this_metadata = std::make_shared<Metadata>(
in->Flags(), shape.size() > 0 ? shape : in->Shape(),
in->Flags(), flx_metadata->Flags(), shape.size() > 0 ? shape : in->Shape(),
component_labels.size() > 0 ? component_labels : in->getComponentLabels(),
in->getAssociated(), in->GetRefinementFunctions());
in->getAssociated(), in->GetRefinementFunctions(),
flx_metadata->GetRefinementFunctions());

this_metadata->SetSparseThresholds(in->GetAllocationThreshold(),
in->GetDeallocationThreshold(),
Expand Down
Loading