Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] remove inline from WriteTaskGraph #1211

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

acreyes
Copy link
Contributor

@acreyes acreyes commented Nov 22, 2024

PR Summary

WriteTaskGraph was still marked inline when moved from tasks.hpp to tasks.cpp leading to linking errors when used.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@pgrete pgrete enabled auto-merge (squash) November 25, 2024 09:07
@pgrete
Copy link
Collaborator

pgrete commented Nov 25, 2024

I'm force merging as the style check once again does not work on forks.

@pgrete pgrete disabled auto-merge November 25, 2024 13:24
@pgrete pgrete merged commit 2fc423a into parthenon-hpc-lab:develop Nov 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants