-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Linear Solver Updates #1174
Open
lroberts36
wants to merge
71
commits into
develop
Choose a base branch
from
lroberts36/add-cg-solver
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
reviewed
Sep 25, 2024
…oberts36/add-cg-solver
…oberts36/add-cg-solver
lroberts36
changed the title
WIP: [Breaking] Linear Solver Updates
[Breaking] Linear Solver Updates
Nov 21, 2024
Yurlungur
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This seems to be a pretty significantly cleanup along with the new features and better performance.
Co-authored-by: Jonah Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds a number of solver related things:
poisson_gmg
example.poisson_gmg
example.To facilitate these changes to the solvers and examples, two small changes are made to the rest of the infrastructure:
SparsePack
s to work with multigrid neighbors and include physical boundary information as well. This is a breaking change, since now physical boundaries are denoted with a large, negative level in the array containing neighbor information inSparsePack
Indexer
.PR Checklist