Bugfix: Resymmetrize logical coordinates #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6/refactor-mesh-constructors
…6/refactor-mesh-constructors
…6/refactor-mesh-constructors
…6/refactor-mesh-constructors
…tor-mesh-constructors
lroberts36
changed the base branch from
develop
to
lroberts36/refactor-mesh-constructors
lroberts36
changed the title
|
It also effects the coordinates of blocks at roundoff, but I don't think this is as big of an issue as the impact on SMR (where the refinement structure was different in some cases with the exact same input). That being said, it probably broke exact symmetry (if it ever existed in any downstream code). |
Yurlungur
approved these changes
Jun 7, 2024
pgrete
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
LGTM and I can confirm that this results in the expected mesh again (though other issue still persist with restarts, but I'll track those down separately).
I suggest to wait clicking merge on this PR until #1055 is in develop, then change the target branch and pull the trigger here.
This way we get a clean history (which may at some point be useful for bisects)
…bugfix-symmetrized-coordinates
lroberts36
changed the base branch from
lroberts36/refactor-mesh-constructors
to
develop
lroberts36
changed the base branch from
develop
to
lroberts36/refactor-mesh-constructors
lroberts36
changed the base branch from
lroberts36/refactor-mesh-constructors
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Originally, Athena++ transformed integer logical coordinates into floating point logical coordinates in the range [-0.5, 0.5]. In #911, I changed this to map to the range [0, 1]. As @pgrete has pointed out, the new range breaks floating point symmetry (see the comment at the end of this athena++ document at the very bottom). This in turn causes static mesh refinement to operate differently due to roundoff error and block coordinates to not be bitwise exact with the original coordinate positions for single tree forests. This PR switches back to symmetrized floating-point logical coordinates and back to the exact algorithm used for finding static refinement regions from before #911.
PR Checklist