-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMR with swarms #1090
SMR with swarms #1090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting to see this in! And it's a nice cleanup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I definitely like to see the negative line count and removing special casing! I think the solution of using the physical coordinates is good for now, but I included some aspirational code for essentially how the neighbor finding should look for general forests.
PR Summary
Static mesh refinement currently fails with particles; particles are communicated to incorrect fine blocks across refinement boundaries. This PR fixes that by changing the way we set the internal neighbor connectivity matrix in the swarm machinery. Instead of a bunch of hardcoded indexing specific to dimension and no refinement, I create test points for each halo neighbor block at the maximum possible refinement level, and test whether those points are contained by any neighbor blocks. Works for neighbor connectivity including across trees and across periodic boundaries.
PR Checklist