Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few Kokkos quality of life improvements #1078

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented May 16, 2024

PR Summary

In #1075 @brryan recently reported that 1D par_reduce doesn't seem to work. I think this is because it's not supported for the all loop patterns, including simd for loops, which are default on CPU builds. I resolve this by just falling back to Kokkos for all loop patterns in 1D.

I also add overloads in 1D for IndexRange instead of a start and end pair of indices. If this is desirable I can add overloads and fallbacks for other patterns and dimensions in a later pull request.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur added bug Something isn't working enhancement New feature or request api labels May 16, 2024
@Yurlungur Yurlungur self-assigned this May 16, 2024
@Yurlungur Yurlungur linked an issue May 16, 2024 that may be closed by this pull request
@Yurlungur Yurlungur mentioned this pull request May 16, 2024
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/prolong_restrict/pr_loops.hpp Show resolved Hide resolved
@Yurlungur Yurlungur enabled auto-merge May 16, 2024 03:51
Copy link
Collaborator

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for working this up @Yurlungur! When this automerges I'll test downstream and if it works I'll close #1075

@Yurlungur Yurlungur merged commit 60820e0 into develop May 16, 2024
49 checks passed
@Yurlungur Yurlungur deleted the jmm/kokkos-qol-tweaks branch May 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1D par_reduce missing
4 participants