A few Kokkos quality of life improvements #1078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In #1075 @brryan recently reported that 1D
par_reduce
doesn't seem to work. I think this is because it's not supported for the all loop patterns, including simd for loops, which are default on CPU builds. I resolve this by just falling back to Kokkos for all loop patterns in 1D.I also add overloads in 1D for
IndexRange
instead of a start and end pair of indices. If this is desirable I can add overloads and fallbacks for other patterns and dimensions in a later pull request.PR Checklist