Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fail on edge case in Mesh Data #1064

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Apr 25, 2024

PR Summary

As discussed in MR #1060 and in the parthenon call, there are edge cases when you add mesh data on a partition. This just prevents you from doing that.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur added the bug Something isn't working label Apr 25, 2024
@Yurlungur Yurlungur self-assigned this Apr 25, 2024
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the comment above still properly reflect this check (basically telling future us' if there's still a need to fix sth)?

@Yurlungur
Copy link
Collaborator Author

Does the comment above still properly reflect this check (basically telling future us' if there's still a need to fix sth)?

It's still relevant if we ever want to make Add work on subsets of the mes. So I'd rather keep it.

@Yurlungur Yurlungur merged commit d9c04f6 into develop Apr 25, 2024
49 checks passed
@Yurlungur Yurlungur deleted the jmm/add-fail-on-edge-case branch April 26, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants