Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installationId on LiveQuery connect #6180

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix installationId on LiveQuery connect #6180

merged 1 commit into from
Nov 4, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Nov 4, 2019

Throws an error and prevents LiveQuery from reconnecting.

Fixes Monitoring installationId.
Allow installationId to be sent to and from client.

To be used with: parse-community/Parse-SDK-JS#977

Throws an error and prevents LiveQuery from reconnecting.

Fixes Monitoring installationId.
Allow installationId to be sent to and from client.
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #6180 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6180      +/-   ##
==========================================
- Coverage   93.81%   93.78%   -0.03%     
==========================================
  Files         167      167              
  Lines       11299    11298       -1     
==========================================
- Hits        10600    10596       -4     
- Misses        699      702       +3
Impacted Files Coverage Δ
src/LiveQuery/RequestSchema.js 100% <ø> (ø) ⬆️
src/LiveQuery/ParseLiveQueryServer.js 90.06% <ø> (-0.07%) ⬇️
src/LiveQuery/Client.js 100% <100%> (ø) ⬆️
src/RestWrite.js 93.42% <0%> (-0.5%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/Routers/PushRouter.js 96.55% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5fed8...f322939. Read the comment docs.

@dplewis dplewis requested a review from acinader November 4, 2019 21:17
@dplewis dplewis merged commit 2533db0 into master Nov 4, 2019
@dplewis dplewis deleted the livequery-schema branch November 4, 2019 21:58
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Throws an error and prevents LiveQuery from reconnecting.

Fixes Monitoring installationId.
Allow installationId to be sent to and from client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants