Add installationId to LiveQuery #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
+ Coverage 91.84% 91.85% +0.01%
==========================================
Files 54 54
Lines 5075 5083 +8
Branches 1142 1145 +3
==========================================
+ Hits 4661 4669 +8
Misses 414 414
Continue to review full report at Codecov.
|
acinader
approved these changes
Nov 4, 2019
src/ParseLiveQuery.js
Outdated
| @@ -88,6 +88,7 @@ const DefaultLiveQueryController = { | |||
| } | |||
| const currentUser = await CoreManager.getUserController().currentUserAsync(); | |||
| const sessionToken = currentUser ? currentUser.getSessionToken() : undefined; | |||
| const installationId = await CoreManager.getInstallationController().currentInstallationId(); | |||
There was a problem hiding this comment.
you should do this async and the current user async together:
const [currentUser, installationId] = await Promise.all([...]);There was a problem hiding this comment.
Done. I keep forgetting about that trick.
This was referenced Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds reconnect for error event from server (already reconnects with web socket error).
Adds backwards compatibility for additionalProperties that do not exist in the server.
This PR will require a server update.
Use Case: Determine which client the live query request was sent from.
Will open a PR separately for the following.