Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint errors on Windows #4364

Merged
merged 8 commits into from
Nov 25, 2017
Merged

Fix eslint errors on Windows #4364

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b19fd17
Fix eslint errors on Windows
addisonElliott Nov 20, 2017
fd17697
Remove linespace ending check in Lint
addisonElliott Nov 22, 2017
820575d
Remove bat file extension from gitattributes
addisonElliott Nov 22, 2017
449487d
Change tabs to spaces
addisonElliott Nov 22, 2017
3daa1c9
Force LF line endings for each file upon downloading
addisonElliott Nov 23, 2017
5da52a4
Merge branch 'master' into fix-eslint-windows-error
addisonElliott Nov 23, 2017
f21f298
Add a few more text files to the gitattributes
addisonElliott Nov 25, 2017
b6f1acf
Added png as binary file to gitattributes file
addisonElliott Nov 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
* text=auto eol=lf

*.js text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add:

  • *.txt
  • *.yml
  • *.sql
    Just to be thorough and cover our travis yml, a text test file and some .sql files we use for Postgres. Wouldn't want anything unexpected to sneak through on those.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Added

*.html text
*.less text
*.json text
*.css text
*.xml text
*.md text

*.sh text