-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eslint errors on Windows #4364
Merged
flovilmart
merged 8 commits into
parse-community:master
from
addisonElliott:fix-eslint-windows-error
Nov 25, 2017
Merged
Fix eslint errors on Windows #4364
flovilmart
merged 8 commits into
parse-community:master
from
addisonElliott:fix-eslint-windows-error
Nov 25, 2017
Commits on Nov 20, 2017
-
On Windows, when run `npm run lint`, a **LOT** of the following errors appeared: ``` error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style ``` This error only occurs on Windows because the `linebreak-style` eslint setting was set to "unix". This is fixed by making the eslint config file a Javascript script and setting the platform based on the build platform. Thus, the `linebreak-style` will be "windows" or "unix" depending on the users platform.
Configuration menu - View commit details
-
Copy full SHA for b19fd17 - Browse repository at this point
Copy the full SHA b19fd17View commit details
Commits on Nov 22, 2017
-
Remove linespace ending check in Lint
Add .gitattributes that will convert line endings automatically to LF when uploading to GitHub
Configuration menu - View commit details
-
Copy full SHA for fd17697 - Browse repository at this point
Copy the full SHA fd17697View commit details -
Remove bat file extension from gitattributes
Include lint check for line endings
Configuration menu - View commit details
-
Copy full SHA for 820575d - Browse repository at this point
Copy the full SHA 820575dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 449487d - Browse repository at this point
Copy the full SHA 449487dView commit details
Commits on Nov 23, 2017
-
Force LF line endings for each file upon downloading
Restore eslint linebreak style check for unix since LF line endings will be enforced
Configuration menu - View commit details
-
Copy full SHA for 3daa1c9 - Browse repository at this point
Copy the full SHA 3daa1c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5da52a4 - Browse repository at this point
Copy the full SHA 5da52a4View commit details
Commits on Nov 25, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f21f298 - Browse repository at this point
Copy the full SHA f21f298View commit details -
Added png as binary file to gitattributes file
This was necessary because git was showing that the CRLF line endings were being converted to LF for PNG files on Windows
Configuration menu - View commit details
-
Copy full SHA for b6f1acf - Browse repository at this point
Copy the full SHA b6f1acfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.