Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint errors on Windows #4364

Merged

Commits on Nov 20, 2017

  1. Fix eslint errors on Windows

    On Windows, when run `npm run lint`, a **LOT** of the following errors
    appeared:
    ```
     error  Expected linebreaks to be 'LF' but found 'CRLF'  linebreak-style
    ```
    
    This error only occurs on Windows because the `linebreak-style` eslint
    setting was set to "unix". This is fixed by making the eslint config
    file a Javascript script and setting the platform based on the build
    platform.
    
    Thus, the `linebreak-style` will be "windows" or "unix" depending on the
    users platform.
    addisonElliott committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    b19fd17 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Remove linespace ending check in Lint

    Add .gitattributes that will convert line endings automatically to LF when uploading to GitHub
    addisonElliott committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    fd17697 View commit details
    Browse the repository at this point in the history
  2. Remove bat file extension from gitattributes

    Include lint check for line endings
    addisonElliott committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    820575d View commit details
    Browse the repository at this point in the history
  3. Change tabs to spaces

    addisonElliott committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    449487d View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2017

  1. Force LF line endings for each file upon downloading

    Restore eslint linebreak style check for unix since LF line endings will be enforced
    addisonElliott committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    3daa1c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5da52a4 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2017

  1. Configuration menu
    Copy the full SHA
    f21f298 View commit details
    Browse the repository at this point in the history
  2. Added png as binary file to gitattributes file

    This was necessary because git was showing that the CRLF line endings were being converted to LF for PNG files on Windows
    addisonElliott committed Nov 25, 2017
    Configuration menu
    Copy the full SHA
    b6f1acf View commit details
    Browse the repository at this point in the history