Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Cypress e2e setup #2552
base: alpha
Are you sure you want to change the base?
test: Cypress e2e setup #2552
Changes from 2 commits
c0ff53d
d3c2faf
6304643
7f4065d
3abf31e
11df53e
6d1e44a
0eefe39
3e70f51
583f8e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 8 in cypress.config.js
GitHub Actions / Lint
Check failure on line 3 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint
Check failure on line 4 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint
Check failure on line 5 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint
Check failure on line 20 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint
Check failure on line 21 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really necessary to wait here? Doesn't cypress handle the loading and continue once the page loading finished?
Check failure on line 23 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint
Check failure on line 28 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint
Check failure on line 29 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint
Check failure on line 44 in cypress/e2e/apps-index.cy.js
GitHub Actions / Lint