-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Cypress e2e setup #2552
base: alpha
Are you sure you want to change the base?
test: Cypress e2e setup #2552
Conversation
Thanks for opening this pull request! |
I will reformat the title to use the proper commit message syntax. |
Uffizzi Ephemeral Environment
|
Could you add the UI test to the CI by adding something like this to ci.yml?
And could you check the failing lint job? |
@mtrezza I have resolved the above. Can you please approve the workflow request ? |
Signed-off-by: Manuel <[email protected]>
Signed-off-by: Manuel <[email protected]>
Signed-off-by: Manuel <[email protected]>
Signed-off-by: Manuel <[email protected]>
@mtrezza Some cypress tests are failing currently. I'll fix them in sometime. |
); | ||
|
||
cy.visit('/') | ||
cy.wait(3000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really necessary to wait here? Doesn't cypress handle the loading and continue once the page loading finished?
Could we move the Cypress tests into a subdirectory And what are the benefits of choosing Cyprus over puppet to you? Is it faster, more popular, more versatile, etc? One criterium we should keep in mind is that we want to make it as easy as possible for contributors to write tests along with their PRs, so we improve the coverage. |
@mehulmathur16 would you want to pick this up again? Or maybe @dplewis? Note there is a bounty on this issue. |
Follow this for running e2e tests on local :
npm dashboard
for running the server.npm run cypress:open
. This script will open cypress UI, then you need to select e2e testing, after which you can run specific tests.OR
npm run cypress:run
.Currently, some tests might fail, as I have made changes to src/ react components, which are not updating while I was testing this out on my local system. The
npm run dashboard
command seems to serve the same UI always.Closes: #2007