LocalDatastore can update from server

[dplewis]

Allows for updating LocalDatastore with server data

Any advice would be helpful

[codecov]

Codecov Report

Merging #734 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   88.74%   88.83%   +0.08%     
==========================================
  Files          53       53              
  Lines        4584     4620      +36     
  Branches     1064     1069       +5     
==========================================
+ Hits         4068     4104      +36     
  Misses        516      516

Impacted Files	Coverage Δ
src/LocalDatastore.js	98.98% <100%> (+0.22%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41010b9...8f66e4a. Read the comment docs.

[flovilmart]

Did you check how the other SDKs implémented those features? I’m not sure the server is properly equipped to ‘sync’ data when it’s been off sync?

_{Sent with GitHawk}

[dplewis]

Did you check how the other SDKs implémented those features?

If by other SDK's you mean iOS and android LDS, I don't believe they have this kind of feature. They do have saveEventually for syncing

I’m not sure the server is properly equipped to ‘sync’ data when it’s been off sync?

I'm not looking for a true sync feature with this PR. Just when network reconnect perform a query.

We could add an optional scheduler that will sync it periodically or with user could call this function whenever they wanted to sync data

[flovilmart]

That’s not what I meant, when you will get network connection again, you will attempt to save object, and may override previous operations. But I guess you already knew that.

_{Sent with GitHawk}

[flovilmart]

The REstController also is not the best spot to get this feature in, as it’s responsibility is solely to connect to the API. It has nothing to do with the LDS.

_{Sent with GitHawk}

[dplewis]

The REstController also is not the best spot to get this feature in

That makes sense. When do you believe the best implementation is? I would like to the SDK to handle it. Any advice would be appreciated

@acinader Thoughts

[dplewis]

@flovilmart How does this look?

[flovilmart]

@dplewis ask @acinader :)

_{Sent with GitHawk}

[acinader]

trying to wrap my head around this....

[acinader]

lgtm. one question about the logger.

[acinader]

any reason not to use parse's logger so this stuff shows up in aggregated logs?

see middlewares, MogoTransform, PromiseRouter, etc. for examples

[dplewis]

something like

const Logger = require('parse-server/lib/logger');

Logger.logger.error(`Error syncing LocalDatastore: ${error}`);
console.log('Error syncing LocalDatastore', error);

[acinader]

Any reason to not follow the exact pattern we have already?

i.e.

https://github.com/parse-community/parse-server/blob/master/src/PromiseRouter.js#L10

import log from './logger';
...
log.error('message', object);
...

and remove the console.log and the eslint exception comment?

[dplewis]

Thats the parse-server repo, there isn't a logger in this repo that I know of.

[acinader]

ha. riiiight. yeah, lgtm. ;) . I don't use the client js sdk is the only lame excuse i have for that one.