Local Datastore #612

dplewis · 2018-07-27T01:15:51Z

This is based on discussion #77

This is a Work In Progress.

codecov · 2018-07-27T01:29:40Z

Codecov Report

Merging #612 into master will increase coverage by 2.88%.
The diff coverage is 98.85%.

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   85.69%   88.57%   +2.88%     
==========================================
  Files          48       53       +5     
  Lines        3928     4535     +607     
  Branches      898     1052     +154     
==========================================
+ Hits         3366     4017     +651     
+ Misses        562      518      -44

Impacted Files	Coverage Δ
src/Parse.js	`84.61% <100%> (+4.01%)`	⬆️
src/equals.js	`100% <100%> (+8%)`	⬆️
src/StorageController.react-native.js	`100% <100%> (+15.78%)`	⬆️
src/CoreManager.js	`100% <100%> (ø)`	⬆️
src/LocalDatastoreController.browser.js	`100% <100%> (ø)`
src/LocalDatastoreController.default.js	`100% <100%> (ø)`
src/LocalDatastoreController.react-native.js	`100% <100%> (ø)`
src/ParseQuery.js	`95.75% <95.94%> (+0.93%)`	⬆️
src/ParseObject.js	`89.47% <98.59%> (+0.73%)`	⬆️
src/LocalDatastore.js	`98.75% <98.75%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6f363...51ac2f1. Read the comment docs.

dplewis · 2018-08-01T20:14:41Z

@flovilmart Can you check Travis for me? I've been having gulp issues.

Also can you do a quick run though of what I've done so far? Its pretty close to being done.

flovilmart · 2018-08-01T20:47:04Z

Error: Cannot find module 'utf-8-validate' from '/home/travis/build/parse-community/Parse-SDK-JS/node_modules/parse/node_modules/ws/lib'

It’s the error that I see before the integration tests, during the browserify build

dplewis · 2018-08-01T20:54:46Z

@flovilmart I got both

Error: Cannot find module 'utf-8-validate' from 'xxx/node_modules/ws/lib'
Error: Cannot find module 'bufferutil' from 'xxx/node_modules/ws/lib'

I tried to npm install --save them but ended up with another error

flovilmart · 2018-08-01T21:10:47Z

Uhm, that’s odd, try reverting ws to an earlier version then :)

dplewis · 2018-08-02T00:49:09Z

@flovilmart I fixed the issue. It was a lot of circular dependency. Since localStorage isn't available I'll have to mock it along with some other tests.

Can you have a quick look through?

flovilmart · 2018-08-02T00:59:55Z

I’ll have a look. The diff hit for coverage is only 21.11% can we do something?

dplewis · 2018-08-02T01:07:29Z

@flovilmart I'll try

flovilmart · 2018-08-09T01:14:02Z

src/LocalDatastore.js

@@ -41,29 +40,30 @@ const LocalDatastore = {
    controller.clear();
  },

-  _handlePinWithName(name: string, object: ParseObject) {
+  _handlePinWithName(name: string, object: any) {


Why loose the typing?

I kept running into a

Uncaught TypeError: Super expression must either be null or a function, not undefined

Whenever I used ParseObject in the tests. I found a fix for it so I'll add the typing back.

You are 💯

flovilmart · 2018-08-09T20:36:15Z

I’ll review over the weekend

dplewis · 2018-08-09T21:27:56Z

integration/test/ParseQueryTest.js

+    });
+  });
+
+  describe('Parse Query Pinning (LocalStorage)', () => {


@flovilmart Quick question? Since I have both in-memory and localStorage available. I want to run the test cases against both without copying them. Would putting describe inside of a for-loop make sense?

Yep it works, otherwise what you can do is put it into a functions and call the function from the specific describe

I just tried putting it in a loop. It also works great with Jasmine Test Explorer too

dplewis · 2018-09-21T23:25:15Z

@flovilmart @acinader Quick Update

Since objects have serverData some of the querying from LDS may not work as intended

query.select() the keys are always present because of server data

object.fetchFromLocalDatastore it currently overrides server data, I'll remove it but that means if you do something like object.set('field', 'will not override') that field will still be set after fetch

object.fetchFromLocalDatastore I'm stuck on the recursion portion of it. I started it but its incomplete. The test is called can fetchFromLocalDatastore break multiple cycle in ParseLocalDatastoreTest.js. If you have time can you look into it?

improve coverage and clean up unused code

flovilmart · 2018-09-22T19:28:21Z

@dplewis thanks! I'll have a look!

acinader

I've read through it all. This looks good to me and I can see it much requested.

Do you think this would be useful in node? cloud code?

acinader · 2018-10-04T16:19:52Z

Could be helpful at this point to make a draft section to go in the guide? I'd be glad to help edit and that could help me try this out too?

dplewis · 2018-10-04T20:43:15Z

@acinader I opened a PR in the docs repo parse-community/docs#558

acinader · 2018-10-04T20:57:30Z

man, that's seriously helpful. I have barely touched the IOS SDK, so this makes more sense now.

flovilmart · 2018-12-16T19:34:21Z

Where do we stand on this one?

dplewis · 2018-12-16T19:35:58Z

It should be good to go!

flovilmart · 2018-12-16T20:43:22Z

Is it completely opt-in? And anyone not wanting the feature should be able to experience no regression?

dplewis · 2018-12-16T20:56:53Z

Yes you have to enable it with Parse.enableLocalDatastore().

flovilmart · 2018-12-16T21:26:12Z

I’ll give a good read and let you merge

flovilmart

Let’s see how it goes!

GoMino · 2019-02-11T20:21:41Z

Hello guys does updating an object while being offline, get sync automatically when network access reappear with this new feature (react-native usage) ?

Can't wait to test the localstorage feature with the upcoming 2.2.0 release 🤩

dplewis · 2019-02-11T20:57:30Z

It currently doesn't exist. Thats something we can implement in the future. I want to play around with this in production for a bit. Feel free to open a PR.

GoMino · 2019-02-12T09:32:38Z

Ok so if I understand correctly this version smoothly enable offline read access to already sync datas.
I will let you know if I have time to add support for write access.

GoMino · 2019-02-13T13:57:01Z

@dplewis is the following doc regarding localstorage (parse-community/docs#558) up to date with the last 2.2.0 release ?

dplewis · 2019-02-13T15:37:55Z

Yes, I also opened a PR to address your sync feature. Waiting for 2.2.0 to be release to npm

GoMino · 2019-02-13T19:18:15Z

Great I will have a look at your pull request #734 when I have time!
First I will test the 2.2.0 release to understand how this new feature is behaving (for offline read only access)...

dplewis added 7 commits July 25, 2018 21:53

initial setup

b10f5a1

object pinning

c82d7ea

initial setup

741dd7c

object pinning

53aa9af

Merge branch 'LDS' of https://github.com/dplewis/Parse-SDK-JS into LDS

0223cec

finished object pinning

5f17d89

fetchfromlocaldatastore

f8ec58f

dplewis mentioned this pull request Jul 27, 2018

Any plans to add Local Datastore for JS SDK? #77

Closed

dplewis added 2 commits August 1, 2018 15:03

Add Query Functionality

e369118

Merge branch 'master' into LDS

39f77ca

remove circular dependencies

66c8acb

dplewis added 3 commits August 2, 2018 16:21

fix unpinallobjects

d444086

ungodly amount of jest test

9fddb7d

Merge branch 'master' into LDS

148708f

flovilmart reviewed Aug 9, 2018

View reviewed changes

dplewis added 3 commits August 9, 2018 13:49

added on destroy remove pin

2d3c9a0

Merge branch 'master' into LDS

c40f9da

coverage improvement

1992198

dplewis requested review from flovilmart and acinader August 9, 2018 20:29

dplewis commented Aug 9, 2018

View reviewed changes

dplewis added 2 commits September 21, 2018 19:05

prevent fetch from overriding server data

baeff04

improve coverage and clean up unused code

lint

00d3cc2

dplewis added 2 commits October 2, 2018 20:57

Merge branch 'master' into LDS

675cd3f

use bfs to avoid recursion

39f89e7

dplewis requested a review from acinader October 4, 2018 01:01

acinader reviewed Oct 4, 2018

View reviewed changes

dplewis mentioned this pull request Oct 4, 2018

Add JS Doc for Local Datastore parse-community/docs#558

Merged

dplewis added 2 commits October 31, 2018 10:45

Merge branch 'master' into LDS

7cac6b9

Merge branch 'master' into LDS

c474b3b

flovilmart approved these changes Dec 22, 2018

View reviewed changes

Merge branch 'master' into LDS

51ac2f1

dplewis merged commit 629a550 into parse-community:master Dec 24, 2018

dplewis deleted the LDS branch December 24, 2018 01:54

cbaker6 mentioned this pull request Sep 3, 2021

How to implement offline storage? parse-community/Parse-SDK-dotNET#360

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Local Datastore #612

Local Datastore #612

dplewis commented Jul 27, 2018 •

edited

Loading

codecov bot commented Jul 27, 2018 •

edited

Loading

dplewis commented Aug 1, 2018

flovilmart commented Aug 1, 2018

dplewis commented Aug 1, 2018

flovilmart commented Aug 1, 2018

dplewis commented Aug 2, 2018

flovilmart commented Aug 2, 2018

dplewis commented Aug 2, 2018

flovilmart Aug 9, 2018

dplewis Aug 9, 2018

flovilmart Aug 9, 2018

flovilmart commented Aug 9, 2018

dplewis Aug 9, 2018 •

edited

Loading

flovilmart Aug 9, 2018

dplewis Aug 9, 2018

dplewis commented Sep 21, 2018 •

edited

Loading

flovilmart commented Sep 22, 2018

acinader left a comment

acinader commented Oct 4, 2018

dplewis commented Oct 4, 2018

acinader commented Oct 4, 2018

flovilmart commented Dec 16, 2018

dplewis commented Dec 16, 2018

flovilmart commented Dec 16, 2018

dplewis commented Dec 16, 2018

flovilmart commented Dec 16, 2018

flovilmart left a comment

GoMino commented Feb 11, 2019

dplewis commented Feb 11, 2019

GoMino commented Feb 12, 2019

GoMino commented Feb 13, 2019

dplewis commented Feb 13, 2019

GoMino commented Feb 13, 2019

Local Datastore #612

Local Datastore #612

Conversation

dplewis commented Jul 27, 2018 • edited Loading

codecov bot commented Jul 27, 2018 • edited Loading

Codecov Report

dplewis commented Aug 1, 2018

flovilmart commented Aug 1, 2018

dplewis commented Aug 1, 2018

flovilmart commented Aug 1, 2018

dplewis commented Aug 2, 2018

flovilmart commented Aug 2, 2018

dplewis commented Aug 2, 2018

flovilmart Aug 9, 2018

Choose a reason for hiding this comment

dplewis Aug 9, 2018

Choose a reason for hiding this comment

flovilmart Aug 9, 2018

Choose a reason for hiding this comment

flovilmart commented Aug 9, 2018

dplewis Aug 9, 2018 • edited Loading

Choose a reason for hiding this comment

flovilmart Aug 9, 2018

Choose a reason for hiding this comment

dplewis Aug 9, 2018

Choose a reason for hiding this comment

dplewis commented Sep 21, 2018 • edited Loading

flovilmart commented Sep 22, 2018

acinader left a comment

Choose a reason for hiding this comment

acinader commented Oct 4, 2018

dplewis commented Oct 4, 2018

acinader commented Oct 4, 2018

flovilmart commented Dec 16, 2018

dplewis commented Dec 16, 2018

flovilmart commented Dec 16, 2018

dplewis commented Dec 16, 2018

flovilmart commented Dec 16, 2018

flovilmart left a comment

Choose a reason for hiding this comment

GoMino commented Feb 11, 2019

dplewis commented Feb 11, 2019

GoMino commented Feb 12, 2019

GoMino commented Feb 13, 2019

dplewis commented Feb 13, 2019

GoMino commented Feb 13, 2019

dplewis commented Jul 27, 2018 •

edited

Loading

codecov bot commented Jul 27, 2018 •

edited

Loading

dplewis Aug 9, 2018 •

edited

Loading

dplewis commented Sep 21, 2018 •

edited

Loading