Skip to content

Check if tracing is enabled #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pepoviola merged 2 commits into from
Nov 11, 2022
Merged

Check if tracing is enabled #582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
738f2e7
Check if tracing is enabled
pepoviola Nov 11, 2022
d4bbf60
fmt
pepoviola Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion javascript/packages/orchestrator/src/orchestrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,10 @@ export async function start(

const monitorIsAvailable = await client.isPodMonitorAvailable();
let jaegerUrl: string;
if (client.providerName === "podman") {
if (
client.providerName === "podman" &&
networkSpec.settings.enable_tracing
) {
const jaegerIp = await client.getNodeIP("tempo");
jaegerUrl = `${jaegerIp}:6831`;
} else if (
Expand Down