Skip to content

Check if tracing is enabled#582

Merged
pepoviola merged 2 commits intomainfrom
fix-podman-substrate
Nov 11, 2022
Merged

Check if tracing is enabled#582
pepoviola merged 2 commits intomainfrom
fix-podman-substrate

Conversation

@pepoviola
Copy link
Collaborator

For podman we assume that the tracing (jaeger) is enabled in the node and that wrong, for example substrate don't use it. So, now you can set enable_tracing to false and will work with substrate.

cc @michalkucharczyk

@pepoviola pepoviola requested a review from wirednkod November 11, 2022 12:33
@michalkucharczyk
Copy link
Contributor

michalkucharczyk commented Nov 11, 2022

Should I use it like this?

[settings]
enable_tracing = false

@pepoviola
Copy link
Collaborator Author

Should I use it like this?

[settings]
enable_tracing = false

Yes, exactly.
Thanks!

@michalkucharczyk
Copy link
Contributor

Maybe the option could be renamed to enable_jaeger_tracing ?

@pepoviola
Copy link
Collaborator Author

Maybe the option could be renamed to enable_jaeger_tracing ?

Yes, make sense. We are planning to start working in the v2 of zombienet. I think this rename make sense there and keep the v1 as is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants