Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Clarify Prometheus exporter options#9427

Merged
1 commit merged intoparitytech:masterfrom
asymmetric:patch-1
Jul 23, 2021
Merged

Clarify Prometheus exporter options#9427
1 commit merged intoparitytech:masterfrom
asymmetric:patch-1

Conversation

@asymmetric
Copy link
Copy Markdown
Contributor

The 'data source' term does not represent a Prometheus concept. What we are exposing here is an exporter.

This is simliar to #9256

The 'data source' term does not represent a Prometheus concept. What we are exposing here is an exporter.
@cla-bot-2021
Copy link
Copy Markdown

cla-bot-2021 bot commented Jul 23, 2021

User @asymmetric, please sign the CLA here.

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 23, 2021
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Jul 23, 2021

bot merge force

@ghost
Copy link
Copy Markdown

ghost commented Jul 23, 2021

Trying merge.

@ghost
Copy link
Copy Markdown

ghost commented Jul 23, 2021

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@ghost ghost merged commit 8bbad73 into paritytech:master Jul 23, 2021
@asymmetric asymmetric deleted the patch-1 branch July 23, 2021 20:26
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants