This repository was archived by the owner on Nov 15, 2023. It is now read-only.
fix prometheus log message terminology#9256
Merged
bkchr merged 1 commit intoparitytech:masterfrom Jul 2, 2021
Merged
Conversation
A prometheus "server" typically refers to the prometheus process running on a central server which connects to various prometheus "exporters" and collects metrics. What is implemented here in substrate is a prometheus exporter. This patch fixes the associated log message to avoid confusion for new users.
Contributor
Author
|
Forgot to mention this for reference: |
gilescope
approved these changes
Jul 2, 2021
bkchr
approved these changes
Jul 2, 2021
Contributor
|
Thank you for this one, was just scratching my head about what the log message actually meant! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prometheus "server" typically refers to the prometheus process running
on a central server which connects to various prometheus "exporters" and
collects metrics. What is implemented here in substrate is a prometheus
exporter.
This patch fixes the associated log message to avoid confusion for new
users.
A*for PR status (one required)B*for changelog (one required)C*for release notes (exactly one required)D*for various implications/requirementsFixes #228orRelated #1337.Refer to the contributing guide for details.
After you've read this notice feel free to remove it.
Thank you!
✄ -----------------------------------------------------------------------------