This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use host max log level when initializing the RuntimeLogger#8655
Merged
2 commits merged intomasterfrom Apr 23, 2021
Merged
Conversation
This should fix performance problems introduced by logging under certain circumstances. Before we always called into the host and the host was doing the log filtering, now as the correct max log level is set, we don't call into the host for every log line to check if it should be logged. However, we would still call into the host to determine if something should be logged when `something=trace` is given as we don't forward the log targets that are enabled.
github-actions
bot
added
the
A3-in_progress
Member
Author
|
@athei could you test if this fixes your benchmarking problem? |
athei
reviewed
Apr 22, 2021
This was referenced Apr 22, 2021
bkchr
added
A0-please_review
shawntabrizi
approved these changes
Apr 23, 2021
athei
approved these changes
Apr 23, 2021
Member
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix performance problems introduced by logging under certain
circumstances. Before we always called into the host and the host was
doing the log filtering, now as the correct max log level is set, we
don't call into the host for every log line to check if it should be
logged. However, we would still call into the host to determine if
something should be logged when
something=traceis given as we don'tforward the log targets that are enabled.
Fixes: #8611