Skip to content

Comments

Tag v0.11.0#666

Merged
hackfisher merged 17 commits intomasterfrom
tag-v0.11.0
Jul 20, 2021
Merged

Tag v0.11.0#666
hackfisher merged 17 commits intomasterfrom
tag-v0.11.0

Conversation

@aurexav
Copy link
Member

@aurexav aurexav commented Jun 11, 2021

No description provided.

@aurexav aurexav marked this pull request as draft June 11, 2021 10:27
@aurexav aurexav added the U-Release [Uncategorized] New release label Jun 11, 2021
@hackfisher
Copy link
Contributor

Need to check HeaderMMR pallet storage name, if dependency is using new frame v2

HeaderMMR: darwinia_header_mmr::{Pallet, Call, Storage} = 31,

Might be "HeaderMMR" --> "DarwiniaHeaderMMR"

Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the changes in darwinia-network/darwinia-common#673 and

https://github.com/darwinia-network/darwinia-common/compare/darwinia-v0.10.0..xavier-darwinia-v0.10.1

This darwinia-common companion and maybe also migration need to be upgraded.

Need carefully review considering the changes in darwinia-v0.10.1

Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current base branch master is using the deprecate commit darwinia-network/darwinia-common@4e2a5df before mmr patch.

After the runtimes in v0.10.1 be applied, the dependency will require to be changed to commit after mmr patch(using new header mmr pallet).

https://github.com/darwinia-network/substrate-update-tracking/issues/19

If we use commits after darwinia-v0.11.1, check the migration differences between these substrate version(companion polkadot can be used as reference).

@hackfisher
Copy link
Contributor

darwinia-common dependency reference:

darwinia-network/darwinia-common@darwinia-v0.10.0...darwinia-v0.10.1

@hackfisher
Copy link
Contributor

hackfisher commented Jul 19, 2021

Related polkadot release with same substrate dependency:

https://github.com/paritytech/polkadot/releases/tag/v0.9.0

What's the changes cause the mandatary upgrade for the nodes?

The new host function mentioned in polkadot v0.9.0? Any related pull request links to this break changes?

@aurexav aurexav marked this pull request as ready for review July 20, 2021 06:30
@boundless-forest
Copy link
Member

The new host function mentioned in polkadot v0.9.0? Any related pull request links to this break changes?

The test result show like this: #662 (comment)

@hackfisher
Copy link
Contributor

The new host function mentioned in polkadot v0.9.0? Any related pull request links to this break changes?

The test result show like this: #662 (comment)

paritytech/substrate#8655

@aurexav
Copy link
Member Author

aurexav commented Jul 20, 2021

The new host function mentioned in polkadot v0.9.0? Any related pull request links to this break changes?

The test result show like this: #662 (comment)

paritytech/substrate#8655

Already linked in CHANGELOG

@hackfisher hackfisher merged commit 07487db into master Jul 20, 2021
@hackfisher hackfisher deleted the tag-v0.11.0 branch July 20, 2021 08:15
boundless-forest pushed a commit that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

U-Release [Uncategorized] New release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants