This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Lower BFT timeout #483
Merged
Lower BFT timeout #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
Aug 2, 2018
| fn begin_round_timeout(&self, round: usize) -> Self::RoundTimeout { | ||
| use std::time::{Instant, Duration}; | ||
|
|
||
| let round = round / 3; |
Contributor
There was a problem hiding this comment.
I think this is OK because we would eventually have a round that surpasses any fixed delay.
rphmeier
added
A8-looksgood
and removed
A0-please_review
rphmeier
approved these changes
Aug 2, 2018
dvdplm
added a commit
that referenced
this pull request
Aug 5, 2018
* master: Add Links to Tags and House Style (#413) Add seed generation tests (#476) Added commit hash to --version (#489) use write_all instead of write (#488) should be MAX_IMPORTING_BLOCKS (#486) Use hex_literal in tests, use rustc-hex from crates (#481) Lower bft timeout (#483) force BFT delay in consensus service, not in proposer logic (#477)
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…check Ensure the receipt for best block can be included in the next block
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.