Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@chevdor
Copy link
Contributor

@chevdor chevdor commented Aug 1, 2018

Related to #474
Following #475

@chevdor chevdor changed the title Add seed generation tests WIP: Add seed generation tests Aug 1, 2018
@chevdor chevdor requested review from arkpar and gavofyork August 1, 2018 12:05
@rphmeier
Copy link
Contributor

rphmeier commented Aug 1, 2018

@chevdor still WIP?

@rphmeier rphmeier added the A3-in_progress Pull request is in progress. No review needed at this stage. label Aug 1, 2018
@chevdor chevdor changed the title WIP: Add seed generation tests Add seed generation tests Aug 1, 2018
@chevdor
Copy link
Contributor Author

chevdor commented Aug 1, 2018

I was waiting for the tests to pass to remove it. All good.

@jacogr jacogr added A0-please_review Pull request needs code review. M4-core and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 1, 2018
@rphmeier rphmeier added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 3, 2018
@rphmeier rphmeier merged commit 14c94f4 into paritytech:master Aug 3, 2018
@chevdor chevdor deleted the will-seed-tests branch August 3, 2018 13:18
dvdplm added a commit that referenced this pull request Aug 5, 2018
* master:
  Add Links to Tags and House Style (#413)
  Add seed generation tests (#476)
  Added commit hash to --version (#489)
  use write_all instead of write (#488)
  should be MAX_IMPORTING_BLOCKS (#486)
  Use hex_literal in tests, use rustc-hex from crates (#481)
  Lower bft timeout (#483)
  force BFT delay in consensus service, not in proposer logic (#477)
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
* change versioning and tagging of releases
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
* remove code related to getting nonce from storage and use RPC call instead

* cargo fmt

* move nonce fetching into Rpc, since it's just an RPC call

* clippy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants