This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Exit signal gets its own trait #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
reviewed
Jul 27, 2018
substrate/cli/src/lib.rs
Outdated
| pub trait IntoExit { | ||
| /// Exit signal type. | ||
| type Exit: Future<Item=(),Error=()> + Send + 'static; | ||
| /// Convet into exit signal. |
| type Exit = future::MapErr<oneshot::Receiver<()>, fn(oneshot::Canceled) -> ()>; | ||
|
|
||
| fn exit_only(&self) -> Self::Exit { | ||
| fn into_exit(self) -> Self::Exit { |
| match cli::prepare_execution::<service::Factory, _, _, _, _>(args, worker, version, load_spec, "parity-polkadot")? { | ||
| cli::Action::ExecutedInternally => (), | ||
| cli::Action::RunService(mut config) => { | ||
| cli::Action::RunService((mut config, worker)) => { |
Contributor
There was a problem hiding this comment.
Hm, I'm not sure how it works. The second item in tuple of Action::RunService is bound to be IntoExit, why it's called worker here? Why worker.configuration() works here?
Member
Author
There was a problem hiding this comment.
Action returns back the same thing that was passed to prepare_execution if it was not used.
rphmeier
approved these changes
Jul 27, 2018
rphmeier
added
A8-looksgood
and removed
A0-please_review
rphmeier
reviewed
Jul 27, 2018
polkadot/collator/src/lib.rs
Outdated
|
|
||
| impl<P, E> IntoExit for CollationNode<P, E> where | ||
| P: ParachainContext + Send + 'static, | ||
| E: Future<Item=(),Error=()> + Send + Clone + 'static |
Contributor
There was a problem hiding this comment.
Clone bound no longer required
arkpar
added
A0-please_review
gavofyork
added
A8-looksgood
and removed
A0-please_review
dvdplm
added a commit
that referenced
this pull request
Jul 30, 2018
* master: (86 commits) Make contract a separate runtime module (#345) Version bump (#450) DB-based blockchain data cache for light nodes (#251) Update libp2p again (#445) Update version on git head change (#444) Fix the public key of bootnode 3 (#441) Update libp2p (#442) Switch to the master branch of libp2p (#427) Export ws port 9944 and add doc (#440) Iterate over overlay to decide which keys to purge (#436) Exit signal gets its own trait (#433) Add docker image (#375) Reset peers.json if the content is not loadable (#405) Limit number of incoming connections (#391) Fix memory leaks in libp2p (#432) Do not queue empty blocks set for import (#431) 5 random fixes (#1) (#435) Chore: fix typo (#434) Prevent building invalid blocks (#430) Better logging for public key mismatch (#429) ...
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424