This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Do not queue empty blocks set for import #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
the
A2-insubstantial
arkpar
approved these changes
Jul 27, 2018
Member
|
CI failed because |
pepyakin
approved these changes
Jul 27, 2018
substrate/network/src/protocol.rs
Outdated
| trace!(target: "sync", "BlockResponse {} from {} with {} blocks", response.id, peer, response.blocks.len()); | ||
| trace!(target: "sync", "BlockResponse {} from {} with {} blocks{}", | ||
| response.id, peer, response.blocks.len(), | ||
| match ( |
Contributor
There was a problem hiding this comment.
Let's avoid such big expressions as an argument, especially when used in positional formatting.
| let mut imported = 0; | ||
|
|
||
| trace!(target:"sync", "Starting import of {} blocks{}", count, | ||
| match ( |
Contributor
There was a problem hiding this comment.
Let's avoid such big expressions as an argument, especially when used in positional formatting.
dvdplm
added a commit
that referenced
this pull request
Jul 30, 2018
* master: (86 commits) Make contract a separate runtime module (#345) Version bump (#450) DB-based blockchain data cache for light nodes (#251) Update libp2p again (#445) Update version on git head change (#444) Fix the public key of bootnode 3 (#441) Update libp2p (#442) Switch to the master branch of libp2p (#427) Export ws port 9944 and add doc (#440) Iterate over overlay to decide which keys to purge (#436) Exit signal gets its own trait (#433) Add docker image (#375) Reset peers.json if the content is not loadable (#405) Limit number of incoming connections (#391) Fix memory leaks in libp2p (#432) Do not queue empty blocks set for import (#431) 5 random fixes (#1) (#435) Chore: fix typo (#434) Prevent building invalid blocks (#430) Better logging for public key mismatch (#429) ...
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Update branches * Bump runtime. * Update again.
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…tor-part-3 Refactor cirrus executor (part 3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserting empty set into the
ImportQueueleads to unnecessary thread wakeups + dumb messages that are spoiling log (likeImported 0 of 0).Also have altered/added two traces. So now log is more detailed: