This repository was archived by the owner on Nov 15, 2023. It is now read-only.
BABE srml tests #3652
Merged
BABE srml tests #3652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Also includes a trivial additional test.
Co-Authored-By: Bastian Köcher <[email protected]>
It currently does not.
This was really nasty, due to a type confusion that showed up as an off-by-1 buffer error.
Most of these were derived from the current output, so they are only useful to guard against regressions.
Also bump impl_version.
Co-Authored-By: André Silva <[email protected]>
Currently, the code emits either no digests (if I don’t call `Session::rotate_session()` or two digests (if I do), which is wrong.
They still don’t work, but this should help debugging.
rphmeier
force-pushed
the
demi/babe-srml-tests
branch
from
ab9953c to
b95395a
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @rphmeier. Based on #3305.