This repository was archived by the owner on Nov 15, 2023. It is now read-only.
BABE SRML tests #3307
Closed
BABE SRML tests #3307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demi-Marie
force-pushed
the
demi/babe-srml-tests
branch
2 times, most recently
from
2bdbda8 to
08d7f6c
Compare
bkchr
reviewed
Aug 6, 2019
Demi-Marie
force-pushed
the
demi/babe-srml-tests
branch
from
5f90ef0 to
1b08501
Compare
Demi-Marie
force-pushed
the
demi/babe-srml-tests
branch
7 times, most recently
from
3c494dc to
8e2e10c
Compare
Demi-Marie
force-pushed
the
demi/babe-srml-tests
branch
4 times, most recently
from
7be68bb to
980af3a
Compare
gavofyork
added
the
A3-in_progress
Contributor
Author
|
|
bkchr
reviewed
Aug 29, 2019
kianenigma
reviewed
Aug 30, 2019
kianenigma
reviewed
Aug 30, 2019
kianenigma
reviewed
Aug 30, 2019
andresilva
previously approved these changes
Sep 3, 2019
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
tests lgtm, some minor nits.
It currently does not.
This was really nasty, due to a type confusion that showed up as an off-by-1 buffer error.
Most of these were derived from the current output, so they are only useful to guard against regressions.
Also bump impl_version.
Co-Authored-By: André Silva <[email protected]>
Currently, the code emits either no digests (if I don’t call `Session::rotate_session()` or two digests (if I do), which is wrong.
They still don’t work, but this should help debugging.
Demi-Marie
force-pushed
the
demi/babe-srml-tests
branch
from
8ccee6c to
3e3d524
Compare
Member
Then I guess he's best placed to review :) |
Contributor
|
Yup, getting it in shape now. Have been holding off until green checkmark (not much to review of a tests PR until then) |
Contributor
Author
|
Superseded by #3652. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @rphmeier. Based on #3305.