This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Documentation for consensus module#2043
Merged
Conversation
|
It looks like @amarrsingh signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
1 similar comment
|
It looks like @amarrsingh signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
amarsinghcodes
changed the title
rphmeier
reviewed
Mar 19, 2019
Contributor
joepetrowski
left a comment
joepetrowski
left a comment
There was a problem hiding this comment.
(sorry for not combining all comments in review)
Just general style comments. Also all lines should be fewer than 120 characters.
Co-Authored-By: AmarRSingh <asinghchrony@protonmail.com>
Co-Authored-By: AmarRSingh <asinghchrony@protonmail.com>
Co-Authored-By: AmarRSingh <asinghchrony@protonmail.com>
Co-Authored-By: AmarRSingh <asinghchrony@protonmail.com>
stanislav-tkach
approved these changes
Mar 28, 2019
gavofyork
reviewed
Mar 29, 2019
gavofyork
reviewed
Mar 29, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* first try * resolve description of grandpa and add links to relevant docs * Update srml/consensus/src/lib.rs Co-Authored-By: AmarRSingh <asinghchrony@protonmail.com> * Can do a relative link here * Update srml/consensus/src/lib.rs Co-Authored-By: AmarRSingh <asinghchrony@protonmail.com> * Update srml/consensus/src/lib.rs Co-Authored-By: AmarRSingh <asinghchrony@protonmail.com> * Update srml/consensus/src/lib.rs Co-Authored-By: AmarRSingh <asinghchrony@protonmail.com> * formatting/style/semantics * missed conflict * style * Update srml/consensus/src/lib.rs * Update srml/consensus/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polkadot-developers/substrate-developer-hub.github.io#25
Changes
consensusmodule at the top oflib.rsnext_sessiontorotate_sessionbecause I don't thinknext_sessionexists but there are comments in this module andsrml/sessionto this function...the name must have changed at some point