rpc: Update jsonrpsee v0.15.1 by lexnv · Pull Request #11939 · paritytech/substrate

lexnv · 2022-07-29T15:28:39Z

This PR updates the jsonrpsee crate from v0.14.0 to v0.15.1.

Jsonrpsee Changes

For full list of changes check: jsonrpsee/releases).

Middleware trait has been split into HttpMiddleware and WsMiddleware to better capture their differences.
Return error from subscription callbacks for better ergonomics and removed the PendingSink concept (you can still manually accept or reject a sink, but otherwise it'll be accepted automatically if you send a message down it).

// cc @jsdw @niklasad1

polkadot companion: paritytech/polkadot#5846
comulus companion: paritytech/cumulus#1487

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

client/beefy/rpc/src/lib.rs

client/rpc/src/author/mod.rs

niklasad1

great LGTM,

as a follow-up we should update the rpc-api with the client trait overrides and feature-gate the client stuff such that
other crates such as subxt can re-use the API definitions from sc-rpc-api without having to bring lots needless dependencies such as the jsonrpsee server stuff.

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

jsdw · 2022-08-01T11:13:57Z

as a follow-up we should update the rpc-api with the client trait overrides and feature-gate the client stuff such that
other crates such as subxt can re-use the API definitions from sc-rpc-api without having to bring lots needless dependencies such as the jsonrpsee server stuff.

Interesting thought; I added an issue in subxt to point at this. Not sure whether we'd want it or not there yet but worth a thought :) paritytech/subxt#605

client/rpc-servers/src/middleware.rs

client/rpc/src/state/mod.rs

jsdw

LGTM but let's remove the middleware code duplication :)

Cargo.lock

niklasad1

Can you revert the unrelated changes in Cargo.lock?
Lots of unrelated bumps that may cause regressions.

Would be better to take care of that in another PR

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

niklasad1

👍

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv · 2022-08-02T17:00:10Z

bot merge

* Bump jsonrpsee to v0.15.1 Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update cargo.lock Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc-servers: Adjust RpcMiddleware to WS and HTTP traits Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc/author: Use `SubscriptionSink` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc/chain: Use `SubscriptionSink` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc/state: Use `SubscriptionSink` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc/finality-grandpa: Use `SubscriptionSink` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc/beefy: Use `SubscriptionSink` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * client: Extract RPC string result from queries Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Apply rust-fmt Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Fix warnings Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Fix testing Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc/tests: Remove trailing comma Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc: Use `SubscriptionResult` for implementations Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc: Remove comment Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc: Delegate middleware calls to `RpcMiddleware` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc: Remove comment Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Revert Cargo.lock Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update Cargo.lock with minimal changes Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc: Update imports for `SubscriptionResult` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Apply cargo fmt Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * rpc/tests: Submit raw json requests to validate DenyUnsafe Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv added 11 commits July 29, 2022 14:03

Bump jsonrpsee to v0.15.1

2d7bcdf

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Update cargo.lock

595b1b9

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc-servers: Adjust RpcMiddleware to WS and HTTP traits

4a63c48

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc/author: Use SubscriptionSink

4e897e1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc/chain: Use SubscriptionSink

eba2554

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc/state: Use SubscriptionSink

0b7ba7f

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc/finality-grandpa: Use SubscriptionSink

5ad1b56

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc/beefy: Use SubscriptionSink

264dd45

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

client: Extract RPC string result from queries

03159c9

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Apply rust-fmt

fd14381

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Fix warnings

ac5ed14

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv requested review from acatangiu, andresilva and athei as code owners July 29, 2022 15:28

github-actions bot added the A0-please_review Pull request needs code review. label Jul 29, 2022

lexnv requested review from bkchr, jsdw and niklasad1 July 29, 2022 15:29

lexnv added A7-needspolkadotpr B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 29, 2022

lexnv added 2 commits July 29, 2022 19:13

Fix testing

6546ff3

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/master' into jsonrpsee_v0.15.1

bb7df13

niklasad1 reviewed Jul 30, 2022

View reviewed changes

client/beefy/rpc/src/lib.rs Outdated Show resolved Hide resolved

niklasad1 reviewed Jul 30, 2022

View reviewed changes

client/beefy/rpc/src/lib.rs Outdated Show resolved Hide resolved

niklasad1 reviewed Jul 30, 2022

View reviewed changes

client/rpc/src/author/mod.rs Outdated Show resolved Hide resolved

niklasad1 approved these changes Jul 30, 2022

View reviewed changes

lexnv added 2 commits August 1, 2022 13:58

rpc/tests: Remove trailing comma

102d8f6

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc: Use SubscriptionResult for implementations

320c0b5

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc: Remove comment

bf603c1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

jsdw mentioned this pull request Aug 1, 2022

Should we reuse the generated RPC API definitions from Substrate? paritytech/subxt#605

Closed

This was referenced Aug 1, 2022

Companion for #11939 paritytech/polkadot#5846

Merged

Companion for #11939 paritytech/cumulus#1487

Merged

jsdw reviewed Aug 1, 2022

View reviewed changes

client/rpc-servers/src/middleware.rs Show resolved Hide resolved

jsdw reviewed Aug 1, 2022

View reviewed changes

client/rpc/src/state/mod.rs Outdated Show resolved Hide resolved

jsdw approved these changes Aug 1, 2022

View reviewed changes

niklasad1 reviewed Aug 1, 2022

View reviewed changes

Cargo.lock Outdated Show resolved Hide resolved

niklasad1 suggested changes Aug 1, 2022

View reviewed changes

lexnv added 7 commits August 1, 2022 17:27

rpc: Delegate middleware calls to RpcMiddleware

f60cb16

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc: Remove comment

8f447a7

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Revert Cargo.lock

baa6127

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/master' into jsonrpsee_v0.15.1

1ac4370

Update Cargo.lock with minimal changes

c9592c3

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

rpc: Update imports for SubscriptionResult

4034180

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Apply cargo fmt

af488aa

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

niklasad1 approved these changes Aug 1, 2022

View reviewed changes

lexnv added 2 commits August 2, 2022 13:00

Merge remote-tracking branch 'origin/master' into jsonrpsee_v0.15.1

08b2108

rpc/tests: Submit raw json requests to validate DenyUnsafe

36cf278

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

paritytech-processbot bot merged commit 9b01569 into master Aug 2, 2022

paritytech-processbot bot deleted the jsonrpsee_v0.15.1 branch August 2, 2022 17:00

gilescope mentioned this pull request Aug 15, 2022

Bump jsonrpsee from 0.14.0 to 0.15.0 paritytech/cumulus#1465

Closed

mclyk mentioned this pull request Sep 7, 2022

bump jsonrpsee to 0.15.1 open-web3-stack/open-runtime-module-library#801

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rpc: Update jsonrpsee v0.15.1#11939

rpc: Update jsonrpsee v0.15.1#11939
paritytech-processbot[bot] merged 25 commits intomasterfrom
jsonrpsee_v0.15.1

lexnv commented Jul 29, 2022 •

edited by niklasad1

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

niklasad1 left a comment •

edited

Loading

Uh oh!

jsdw commented Aug 1, 2022

Uh oh!

Uh oh!

Uh oh!

jsdw left a comment

Uh oh!

Uh oh!

niklasad1 left a comment •

edited

Loading

Uh oh!

niklasad1 left a comment

Uh oh!

lexnv commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lexnv commented Jul 29, 2022 • edited by niklasad1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jsonrpsee Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

niklasad1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsdw commented Aug 1, 2022

Uh oh!

Uh oh!

Uh oh!

jsdw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

niklasad1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

niklasad1 left a comment

Choose a reason for hiding this comment

Uh oh!

lexnv commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lexnv commented Jul 29, 2022 •

edited by niklasad1

Loading

niklasad1 left a comment •

edited

Loading

niklasad1 left a comment •

edited

Loading