Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #11939#5846

Merged
bkchr merged 9 commits intomasterfrom
jsonrpsee_v0.15.1
Aug 3, 2022
Merged

Companion for #11939#5846
bkchr merged 9 commits intomasterfrom
jsonrpsee_v0.15.1

Conversation

@lexnv
Copy link
Contributor

@lexnv lexnv commented Aug 1, 2022 •
edited by ggwpez
Loading

Companion for paritytech/substrate#11939

Cumulus companion: paritytech/cumulus#1487

lexnv added 3 commits July 29, 2022 14:26
@lexnv
Bump jsonrpsee to v0.15.1
0123448 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Update cargo.lock
7ac38f4 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Merge remote-tracking branch 'origin/master' into jsonrpsee_v0.15.1
372dc64 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. labels Aug 1, 2022
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 1, 2022
@lexnv lexnv mentioned this pull request Aug 1, 2022
Merged
@jsdw
Copy link

jsdw commented Aug 1, 2022

The changes look good, though I note that the Cargo.lock file still now has a mixture of references to jsonrpsee 0.15 and 0.14 (perhaps via old-substrate-master and then this, so not actually an issue?).

@jsdw jsdw requested a review from niklasad1 August 1, 2022 14:12
@niklasad1
Copy link
Contributor

niklasad1 commented Aug 1, 2022

The changes look good, though I note that the Cargo.lock file still now has a mixture of references to jsonrpsee 0.15 and 0.14 (perhaps via old-substrate-master and then this, so not actually an issue?).

Yes, substrate master is still dependency so that makes sense,

niklasad1
niklasad1 reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that Cargo.lock contains lots of bumped deps that isn't related to jsonrpsee.

Can you downgrade them or update them in another PR?

@paritytech-processbot
Copy link

paritytech-processbot bot commented Aug 2, 2022

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented Aug 2, 2022

Merge cancelled due to error. Error: Statuses failed for bdd10bd

niklasad1 and others added 2 commits August 3, 2022 09:30
@niklasad1
update substrate master
9f16710
@ggwpez
Allow benchmark checks to fail
1685e47 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@lexnv lexnv requested a review from a team as a code owner August 3, 2022 08:59
@paritytech-ci paritytech-ci requested a review from a team August 3, 2022 08:59
@paritytech-ci paritytech-ci requested a review from a team August 3, 2022 09:51
@bkchr bkchr merged commit 00bad26 into master Aug 3, 2022
@bkchr bkchr deleted the jsonrpsee_v0.15.1 branch August 3, 2022 10:23
ordian added a commit that referenced this pull request Aug 3, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
37f9cd7 
* master:
  Companion for #11939 (#5846)
  Bump tracing from 0.1.34 to 0.1.35 (#5737)
  Co #11952: Remove `remove_member_wrong_refund` from `phragmen` weights (#5848)
  Add release-v* rule to common-refs (#5847)
  update weights (#5844)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@jsdw jsdw jsdw approved these changes

@coderobe coderobe coderobe approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lexnv @jsdw @niklasad1 @coderobe @bkchr @ggwpez