Skip to content
This repository was archived by the owner on Apr 19, 2022. It is now read-only.

Conversation

@andresilva
Copy link
Contributor

This is necessary for publishing to crates.io (a snappy crate already exists there).

@andresilva andresilva requested a review from dvdplm August 27, 2018 11:07
@andresilva
Copy link
Contributor Author

I also ran rustfmt on this and added a config file to use tabs instead of spaces.

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo repository metadata key

authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT/Apache-2.0/BSD"
description = "Native bindings to libsnappy"
readme = "README.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a repository key is helpful.

@andresilva andresilva force-pushed the andre/rename-parity-snappy branch from 02ad8c6 to 38a20c7 Compare August 29, 2018 11:16
All of the source code already had headers licensing under GPLv3, but the repo
was missing the LICENSE file and the license was wrongly specified in Cargo.toml
@andresilva andresilva force-pushed the andre/rename-parity-snappy branch from 29ec51b to e7eb0f9 Compare August 29, 2018 13:40
@andresilva andresilva merged commit 4111c2a into master Aug 30, 2018
@debris debris deleted the andre/rename-parity-snappy branch September 12, 2018 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants