Rename crate to parity-rocksdb #18
Conversation
|
I bumped the version to |
|
I also fixed some tests that were disabled. |
Cargo.toml
Outdated
| version = "0.4.5" | ||
| authors = ["Tyler Neely <[email protected]>", "David Greenberg <[email protected]>"] | ||
| version = "0.5.0" | ||
| authors = ["Parity Technologies <[email protected]>"] |
There was a problem hiding this comment.
I'd probably keep the original authors in there too, like authors = ["Tyler Neely <[email protected]>", "David Greenberg <[email protected]>, "Parity Technologies <[email protected]>"]
|
Closes #16 |
|
Added the upstream authors as well. I still need to update the |
andresilva
force-pushed
the
andre/rename-crate
branch
from
fd97cb4 to
106c476
Compare
andresilva
force-pushed
the
andre/rename-crate
branch
7 times, most recently
from
4af5a7b to
22bb6ff
Compare
Summary: sysmacros.h should be included in OS_ANDROID build as well otherwise the compile would complain: error: use of undeclared identifier 'major'. Fixes facebook/rocksdb#4231 Pull Request resolved: facebook/rocksdb#4232 Differential Revision: D9217350 Pulled By: maysamyabandeh fbshipit-source-id: 21f4b62dbbda3163120ac0b38b95d95d35d67dce
andresilva
force-pushed
the
andre/rename-crate
branch
from
22bb6ff to
f1f1f6f
Compare
rocksdb-sys/build.rs
Outdated
There was a problem hiding this comment.
Is CARGO_CFG_TARGET_OS set automatically when cargo runs, i.e. is it a "standard" env var? What is the default?
There was a problem hiding this comment.
Yes, it is set by cargo depending on the OS the current build is targeting. This would be the same as if cfg!(target_os = "android") {} but the cfg! macro doesn't do the right thing when cross-compiling.
There was a problem hiding this comment.
Nit: shouldn't that be an expect("...") instead of unwrap_or_default()?
andresilva
force-pushed
the
andre/rename-crate
branch
from
f1f1f6f to
3935cd0
Compare
andresilva
force-pushed
the
andre/rename-crate
branch
from
51cf912 to
eddd5c1
Compare
andresilva
force-pushed
the
andre/rename-crate
branch
from
bc4eabd to
3ad095f
Compare
This is necessary to allow publishing to crates.io. Merge only after paritytech/rust-snappy#6 since we'll want to change our snappy dependency to the one we'll publish to crates.io.