This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Companion PR to substrate Rename StorageMap::exists to ::contains_key#827
Closed
Companion PR to substrate Rename StorageMap::exists to ::contains_key#827
Conversation
|
It looks like @apopiak signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Contributor
Author
|
@bkchr Not sure what's up with the message. |
Contributor
|
@apopiak run |
Contributor
Author
|
Also unsure how this import could not resolve 😅 |
Member
|
#816 this needs to be merged first. |
apopiak
force-pushed
the
apopiak-rename-exists-to-contains-key
branch
from
2aa160b to
8ab4509
Compare
bkchr
suggested changes
Feb 10, 2020
This reverts commit 9239d7e.
Member
|
Superseded by #834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes usages of
StorageMap::exists(key)by using the newStorageMap::contains_key(key)introduced in paritytech/substrate#4847 instead.See Issue paritytech/substrate#4839 for the motivation.