This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
gavofyork
added
the
A2-insubstantial
gavofyork
added
A0-please_review
gavofyork
added
the
B0-silent
Closed
bkchr
reviewed
Feb 9, 2020
|
|
||
| let exit = inner_exit_2.clone(); | ||
| tokio::spawn(future::select(res.boxed(), exit)); | ||
| tokio::spawn(res.boxed()); |
Contributor
There was a problem hiding this comment.
Yes there is a test for that but in the other branch. I will make another PR to add it now
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
* more tests for finality relay * clippy * remove env_logger dep * fmt * more clippy * removed prune_unjustified_headers * review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings it up to date with the latest Substrate.