Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

[don't merge] try-runtime testing #5596

Closed
coderobe wants to merge 6 commits into from
Closed

[don't merge] try-runtime testing #5596

coderobe wants to merge 6 commits into from

Conversation

@coderobe
Copy link
Contributor

@coderobe coderobe commented May 25, 2022

No description provided.

coderobe and others added 4 commits May 25, 2022 11:34
@coderobe
Update substrate branch
edd0c91
@coderobe
bump version to 0.9.23
7dd6897
@coderobe
bump spec_version to 9230
82989d0
@nazar-pc @coderobe
Companion for #11415 (WeightToFee) (#5525)
8431647 
* Companion for paritytech/substrate#11415

* Rename `WeightToFee::calc()` to `WeightToFee::wight_to_fee()`

* Fix typo

* Fix compile errors

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
@coderobe coderobe self-assigned this May 25, 2022
@coderobe
Copy link
Contributor Author

coderobe commented May 25, 2022

/cmd queue -v RUST_LOG=remote-ext=debug,runtime=trace -c try-runtime $ --chain=polkadot-dev --execution=Wasm on-runtime-upgrade live --uri wss://polkadot-try-runtime-node.parity-chains.parity.io:443

@command-bot
Copy link

command-bot bot commented May 25, 2022 •
edited
Loading

@coderobe https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1592676 was started for your command cargo run --release --quiet --features=try-runtime try-runtime --chain=polkadot-dev --execution=Wasm on-runtime-upgrade live --uri wss://polkadot-try-runtime-node.parity-chains.parity.io:443. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 1-6c47febb-ace3-4e7a-a14d-3f20ab9c8cb8 to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 25, 2022

@coderobe Command cargo run --release --quiet --features=try-runtime try-runtime --chain=polkadot-dev --execution=Wasm on-runtime-upgrade live --uri wss://polkadot-try-runtime-node.parity-chains.parity.io:443 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1592676 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1592676/artifacts/download.

@coderobe
Copy link
Contributor Author

coderobe commented May 25, 2022

getting a whole lot of 2022-05-25 13:52:01.584 ERROR main frame_support::storage: (key, value) failed to decode at [116, 221, 112, 45, 164, 111, 119, 215, 172, 247, 127, 90, 72, 212, 175, 125, 98, 85, 106, 133, 252, 183, 198, 27, 44, 108, 117, 9, 36, 132, 107, 21, 255, 245, 33, 197, 150, 167, 223, 193, 34, 120, 113, 156, 85, 62, 118, 83, 112, 161, 211, 216, 207, 92, 36, 91, 6, 189, 138, 200, 252, 4, 145, 241, 130, 112, 242, 193, 165, 29, 88, 118]: Error in the try-runtime logs cc @kianenigma is this expected?

@coderobe coderobe mentioned this pull request May 25, 2022
Closed
18 tasks
@coderobe
Copy link
Contributor Author

coderobe commented May 27, 2022

/cmd queue -v RUST_LOG=remote-ext=debug,runtime=trace -c try-runtime $ --chain=kusama-dev --execution=Wasm on-runtime-upgrade live --uri wss://kusama-try-runtime-node.parity-chains.parity.io:443

@command-bot
Copy link

command-bot bot commented May 27, 2022 •
edited
Loading

@coderobe https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1595620 was started for your command cargo run --release --quiet --features=try-runtime try-runtime --chain=kusama-dev --execution=Wasm on-runtime-upgrade live --uri wss://kusama-try-runtime-node.parity-chains.parity.io:443. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 1-8ac0b84c-77df-478f-9764-73d51bd0b255 to cancel this command or /cmd cancel to cancel all commands in this pull request.

@niklasad1
Copy link
Contributor

niklasad1 commented May 27, 2022

@coderobe Kian is on vacation without internet for a while.

//cc @shawntabrizi @ggwpez perhaps you guys can help with this? 🙏

@command-bot
Copy link

command-bot bot commented May 27, 2022

@coderobe Command cargo run --release --quiet --features=try-runtime try-runtime --chain=kusama-dev --execution=Wasm on-runtime-upgrade live --uri wss://kusama-try-runtime-node.parity-chains.parity.io:443 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1595620 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1595620/artifacts/download.

coderobe added 2 commits May 27, 2022 15:26
@coderobe
update substrate (#5602)
87f3a95
@coderobe
update weights (#5601) (#5609)
a7e188c 
* polkadot: update weights

* kusama: update weights

* westend: update weights

* rococo: update weights
@ggwpez
Copy link
Member

ggwpez commented May 30, 2022

It reports spec version mismatch (local 9230 != remote 9200). This could cause some issues, but when I query the version of that node, it prints 0.9.22-17c7b9594ae.
Something does not add up here.

Context from that:
The hex encoded key is 74dd702da46f77d7acf77f5a48d4af7d62556a85fcb7c61b2c6c750924846b15fff521c596a7dfc12278719c553e765370a1d3d8cf5c245b06bd8ac8fc0491f18270f2c1a51d5876. Longest prefix for that is 74dd702da46f77d7acf77f5a48d4af7d62556a85fcb7c61b2c6c750924846b15 with key voterList listNodes.

@ggwpez
Copy link
Member

ggwpez commented May 31, 2022

/cmd queue -v RUST_LOG=remote-ext=debug,runtime=trace -c try-runtime $ --chain=kusama-dev --execution=Wasm on-runtime-upgrade live --uri wss://kusama-try-runtime-node.parity-chains.parity.io:443

@command-bot
Copy link

command-bot bot commented May 31, 2022 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1600561 was started for your command cargo run --release --quiet --features=try-runtime try-runtime --chain=kusama-dev --execution=Wasm on-runtime-upgrade live --uri wss://kusama-try-runtime-node.parity-chains.parity.io:443. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 2-af907317-0622-4ec5-9c52-c77e3e32f5cd to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 31, 2022

@ggwpez Command cargo run --release --quiet --features=try-runtime try-runtime --chain=kusama-dev --execution=Wasm on-runtime-upgrade live --uri wss://kusama-try-runtime-node.parity-chains.parity.io:443 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1600561 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1600561/artifacts/download.

@dvdplm
Copy link
Contributor

dvdplm commented May 31, 2022

@ggwpez Seems like the last run finished successfully?

2022-05-31 12:11:49.308  INFO main try-runtime::cli: TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = 18446744073709551615, total weight = 2000000000000 (9223372.036854776)

@ggwpez ggwpez mentioned this pull request May 31, 2022
Merged
1 task
@ggwpez
Copy link
Member

ggwpez commented May 31, 2022 •
edited
Loading

Seems like the last run finished successfully?

It still errors with a decode error. But now at-least the spec version is right. I assume the last Kusama rutime was not live as @coderobe ran the last migration.
It therefore skipped one runtime and printed a version different from now, so I could not reproduce it.

Now I can locally reproduce it. Maybe has something to do with this https://github.com/paritytech/substrate/pull/11357/files#r885585728
Native runtime errors with Could not decode Node::score.

@ggwpez
Copy link
Member

ggwpez commented May 31, 2022

Okay I think the error can be ignored. The bags-list migration AddScore tries to decode the list elements with the old format and then migrates all of the ones where it succeeds to the new format.
But in this case it prints all the decode errors since it already migrated them successfully in the past.
I think the errors come from decoding here which we could probably change to look less scary.

@shawntabrizi
Copy link
Member

shawntabrizi commented May 31, 2022

Yes I agree. As long as the try-runtime migration itself is completing successfully, then you dont need to worry about some random logged errors, which are coming from other places like SP-IO

@coderobe
Copy link
Contributor Author

coderobe commented May 31, 2022

Ok, so we can continue with the release?

@ggwpez
Copy link
Member

ggwpez commented May 31, 2022

Ok, so we can continue with the release?

The migration works fine so I think so.

@coderobe coderobe closed this Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@coderobe coderobe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@coderobe @niklasad1 @ggwpez @dvdplm @shawntabrizi @nazar-pc