-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
|
Looks like only a few extrinsics changed on swc. Some random samples should still be checked manually to see if there are bugs in swc. The only one that really asymptotically increased is the |
| .saturating_add((47_366_000 as Weight).saturating_mul(v as Weight)) | ||
| // Standard Error: 40_000 | ||
| .saturating_add((240_000 as Weight).saturating_mul(d as Weight)) | ||
| .saturating_add((48_208_000 as Weight).saturating_mul(v as Weight)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big jump up of weight value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git diff is a bit confusing here, but parameter v is nearly the same as before.
Paramete d got kicked out. This is only a very small increase.
| (4_943_000 as Weight) | ||
| // Standard Error: 2_000 | ||
| .saturating_add((3_798_000 as Weight).saturating_mul(c as Weight)) | ||
| (11_289_000 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
≈x2 jump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constant component does not really matter here compared to the component c.
c goes up to 1000 for this benchmark. SWC will soon take the correct slope maxima into account to simplify these comparisions.
* polkadot: update weights * kusama: update weights * westend: update weights * rococo: update weights
* polkadot: update weights * kusama: update weights * westend: update weights * rococo: update weights

this PR will also be backported to the current release branch once reviewed & merged