This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make xcm-simulator async with more tests#3618
Merged
7 commits merged intoparitytech:masterfrom Aug 17, 2021
Merged
Conversation
Contributor
Author
|
Request review by @shaunxw @kianenigma @apopiak @shawntabrizi and anyone else interested in the xcm-simulator cc @girazoki for test examples using xcm-simulator |
Closed
apopiak
added
A0-please_review
KiChjang
reviewed
Aug 14, 2021
KiChjang
reviewed
Aug 14, 2021
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Contributor
|
Let's get this in soon? |
Contributor
Author
|
The previous PR which contained the same code (#3546 ) was approved by shaunxw and kianenigma . This PR is approved by @apopiak and was reviewed by keith. Is there anything blocking this @shawntabrizi ? |
shawntabrizi
approved these changes
Aug 17, 2021
Member
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes work from #3546 and puts them on top of master.
Adds tests from #3537 to xcm-simulator (except teleport_assets)
Also makes message processing asynchronous and pulls it out from the test externalities environment to allow for the processing of messages that go back to the origin chain. The previous implementation ran into borrowing issues in the underlying
RefCells when sending messages back to the origin. Messages are processed after the closure passed totest_ext.execute_with().