This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I will stall this for now halfway through integrating BABE until paritytech/substrate#3296 lands. There seems to a lot of assumptions made in the polkadot code about crypto concrete types which might be affected by the new key mgmt system. |
gavofyork
added
the
A3-in_progress
Member
|
@kianenigma will this include the content of #342 ? |
Contributor
Author
Ideally yes, It is on my todo list up top. |
Co-Authored-By: Robert Habermeier <rphmeier@gmail.com>
kianenigma
commented
Aug 7, 2019
collator/src/lib.rs
Outdated
| let authorities = try_fr!(api.authorities(&id)); | ||
| // TODO: double check this. It makes sense bc other occurances of `authorities` | ||
| // has been refactored to this. | ||
| let authorities = try_fr!(api.validators(&id)); |
kianenigma
commented
Aug 7, 2019
primitives/src/lib.rs
Outdated
| /// that 32 bits may be multiplied with a balance in 128 bits without worrying about overflow. | ||
| pub type Balance = u128; | ||
|
|
||
| // TODO: I don't get why this was defined here. It was aura so I change it to babe but regardless of that |
Contributor
Author
There was a problem hiding this comment.
yeah, I still agree with my note. If the crypto key type is defined inside the babe module and exported via babe::AuthorityId then all of them should have the same look. sth like:
pub type BabePair = babe::AuthorityPair;
pub type BabeId = babe::AuthorityId;
kianenigma
commented
Aug 7, 2019
| timestamp = { package = "srml-timestamp", git = "https://github.com/paritytech/substrate", default-features = false, branch = "polkadot-master" } | ||
| treasury = { package = "srml-treasury", git = "https://github.com/paritytech/substrate", default-features = false, branch = "polkadot-master" } | ||
| version = { package = "sr-version", git = "https://github.com/paritytech/substrate", default-features = false, branch = "polkadot-master" } | ||
| babe = { package = "srml-babe", git = "https://github.com/paritytech/substrate", default-features = false, branch = "polkadot-master" } |
Contributor
Author
There was a problem hiding this comment.
I hate this myself. Should refactor them to:
babecrate should always point to thecoreportionsrml_babeshould point to the srml portion.
kianenigma
commented
Aug 7, 2019
kianenigma
commented
Aug 7, 2019
validation/src/lib.rs
Outdated
| let authorities = self.client.runtime_api().authorities(&id)?; | ||
| // TODO: This used to use AuraApi and now it uses validators from parachainHost, as | ||
| // recommended by Rob. Please double and triple check. | ||
| let authorities = self.client.runtime_api().validators(&id)?; |
kianenigma
added
A0-please_review
rphmeier
added
A0-please_review
gavofyork
reviewed
Aug 12, 2019
gavofyork
reviewed
Aug 12, 2019
gavofyork
reviewed
Aug 12, 2019
Contributor
|
I didn't manage to get an alice/bob chain validating after the key refactoring was put in. the chain spec needs a look taken at |
Contributor
|
I got alice authoring blocks. Didn't get her to connect to Bob, though. I'd suggest we merge this already and deal with anything else in a follow-up PR. There are other PRs blocked on unrelated changes within this. |
gavofyork
approved these changes
Aug 12, 2019
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
* verify justifications from runtime * unreachable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #221
TODO:
FindAuthor.aura. Both should be replaced withbabenow.system::CheckGenesis<Runtime>--devchain workscc @jacogr I am doing the testing with UI along the way but if you also want to give it a try would be great.