This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Integrate srml/im-online #342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
commented
Jul 26, 2019
| }), | ||
| im_online: Some(ImOnlineConfig{ | ||
| gossip_at: 0, | ||
| last_new_era_start: 0, |
Author
There was a problem hiding this comment.
We can remove those two properties from the config in the next version of the module.
4 tasks
Contributor
|
i had a quick look and it looks interesting from a layman's perspective |
12 tasks
rphmeier
reviewed
Aug 7, 2019
rphmeier
reviewed
Aug 7, 2019
Co-Authored-By: Robert Habermeier <[email protected]>
Contributor
|
closed via #353 |
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
imstar15
pushed a commit
to imstar15/polkadot
that referenced
this pull request
Aug 25, 2021
…itytech#342) Currently validation data is shared by using a well known key between the parachain system pallet and the validate block implementation. This pr changes this by passing the parachain system directly to the validate block implementation to make use of it. Besides that, we also store the validation params in some thread local variable to make it inspectable by parachain system. This moves the validation of validation data and validation params to the parachain system pallet directly, instead of having this hidden inside the validate block implementation. Fixes: paritytech/cumulus#217
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the basic version of the module which was merged a week ago.
There will be some follow-up PR when the module supports integration with slashing.