This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
Contributor
|
This looks fine to me, though if you want to go ahead and add a matrix message step it would look something like: |
lovelaced
suggested changes
Mar 15, 2021
* Change something * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/ * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/ * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ * cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ * cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ Co-authored-by: Parity Benchmarking Bot <admin@parity.io>
Currently we will take all leaves and give that to the overseer on startup, but this is a bad idea when the finality is lagging for example. There can be many of unfinalized leaves, we don't even need to look at anymore. To solve this, the pr adds a maximum of 4 leaves we forward to the overseer and the pr also checks that we only pass uncles of the best block.
…ons per block) (#2358) * service: update for substrate PR #7640 * update substrate * Add Pallet Babe to Integration Tests Runtime Co-authored-by: André Silva <andrerfosilva@gmail.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Companion for Substrate#8386 paritytech/substrate#8386 * "Update Substrate" Co-authored-by: parity-processbot <>
* Introduce collation fetching protocol also move to mod.rs * Allow `PeerId`s in requests to network bridge. * Fix availability distribution tests. * Move CompressedPoV to primitives. * Request based collator protocol: validator side - Missing: tests - Collator side - don't connect, if not connected * Fixes. * Basic request based collator side. * Minor fix on collator side. * Don't connect in requests in collation protocol. Also some cleanup. * Fix PoV distribution * Bump substrate * Add back metrics + whitespace fixes. * Add back missing spans. * More cleanup. * Guide update. * Fix tests * Handle results in tests. * Fix weird compilation issue. * Add missing ) * Get rid of dead code. * Get rid of redundant import. * Fix runtime build. * Cleanup. * Fix wasm build. * Format fixes. Thanks @andronik !
…ime macro) (#2629) * Replace 'Module' with 'Pallet'. * "Update Substrate" * fix babe usage * fix benchmark Co-authored-by: parity-processbot <> Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
Breaks compatibility for distributing PoV and PersistentValidationData between validators. Ref #2442
* Update for the new substrate client API * Code review suggestions * Update substrate
* Don't accept incoming connections for collators on the `Collation` peer set. * Better docs.
* master: Don't accept incoming connections for collators (#2644) Improve the logging (#2645) Update for the new substrate client API (#2570) integrate faster erasure code (#2608) Companion for #8372 (Replace 'Module' with 'Pallet' in construct_runtime macro) (#2629) Request based collation fetching (#2621) Companion for Substrate#8386 (#2634) Polkadot companion for Substrate PR #7640 (Store multiple Justifications per block) (#2358) yet another set of logging improvements (#2638) Reduce number of active leaves at startup (#2631) re benchmark (#2630) Fix wrong deposit amount in council voters. (#2562) Add /data symlink to Docker containers (#2627) Companion for sub/8176 (#2622) Remove TODO from substrate#2986 (#2628) update ring to 0.16.20 (#2626) New slots/auctions architecture (#2294) add tracing when no assignment in candidate selection (#2623) Backing and collator protocol traces including para-id (#2620) more diagnostic logs for approval-voting (#2618)
Author
Thanks, fixed in 86333c5.
This is 6 hours, we run fuzzers for 5 hours, 1 extra hour should be enough for builds. |
Contributor
|
I meant, in general. Are we good running fuzzing on rather weak public github hosts? |
Author
Well, we want something working now. So I'd say it's good as is for now until we have more CI dev-time to borrow. |
Contributor
|
Everything looks good. Maybe give them a debug run before the merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/paritytech/ci_cd/issues/64.
The initial version doesn't have automatic notification on failure, but that could be added later. I've spent too much on it already.