Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

restructure polkadot-node-jaeger#2642

Merged
drahnr merged 8 commits intomasterfrom
bernhard-polkadot-refactor-jaeger
Mar 19, 2021
Merged

restructure polkadot-node-jaeger#2642
drahnr merged 8 commits intomasterfrom
bernhard-polkadot-refactor-jaeger

Conversation

@drahnr
Copy link
Contributor

@drahnr drahnr commented Mar 18, 2021 •
edited
Loading

Make the jaeger API only usable in one way in order to avoid future confusion.

  • remove the builder pattern
  • use jaeger::Span::new() for arbitrary types that implement new trait LazyIdentEval.
  • apply jaeger API changes to the codebase

@drahnr drahnr added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 18, 2021
@drahnr drahnr self-assigned this Mar 18, 2021
@drahnr drahnr added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 19, 2021
@drahnr drahnr marked this pull request as ready for review March 19, 2021 11:26
@drahnr
Copy link
Contributor Author

drahnr commented Mar 19, 2021

New usage pattern is defined here: https://github.com/paritytech/polkadot/pull/2642/files#diff-0f31587cb20443f483bfad5818d9f7c782f8b93da7947f6670ca3f226add85a1R22-R46

@drahnr drahnr merged commit 10b7497 into master Mar 19, 2021
@drahnr drahnr deleted the bernhard-polkadot-refactor-jaeger branch March 19, 2021 15:51
ordian added a commit that referenced this pull request Mar 19, 2021
@ordian
Merge branch 'master' into ao-ci-fuzzer-jobs
89cf1a6 
* master:
  bump reed-solomon-novelpoly to v0.0.3 (#2650)
  restructure polkadot-node-jaeger (#2642)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eskimor eskimor eskimor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@drahnr drahnr

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drahnr @eskimor