This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Print an error if a collator connects to a node without real-overseer#2563
Merged
ordian merged 2 commits intoparitytech:masterfrom Mar 5, 2021
Merged
Print an error if a collator connects to a node without real-overseer#2563ordian merged 2 commits intoparitytech:masterfrom
ordian merged 2 commits intoparitytech:masterfrom
Conversation
tomaka
added
A0-please_review
ordian
approved these changes
Mar 4, 2021
|
I didn't observe a warning when running https://github.com/paritytech/polkadot/blob/master/parachain/test-parachains/adder/collator/README.md with validators w/o |
Contributor
|
Nice. This will partially address #2546 |
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Contributor
Author
Good question. |
|
Nice |
ordian
reviewed
Mar 5, 2021
| if protocol == "/polkadot/collation/1" { | ||
| tracing::warn!( | ||
| "Incoming collator on a node with parachains disabled. This warning \ | ||
| is harmless and is here to warn developers that they might have |
There was a problem hiding this comment.
you probably meant to use \ after everyline? but that's fine as well
ordian
added a commit
that referenced
this pull request
Mar 9, 2021
* master: Make Substrate deps uniform (#2589) Mostly, let guide reflect #2579 (#2583) add accountkey20 conversion impls (#2576) Substrate companion #8275 (#2575) Make warning nicer (#2569) Print an error if a collator connects to a node without real-overseer (#2563) add log message when real-overseer is enabled (#2565) Jaeger spans for availability distribution (#2559) Fix links in docs. (#2556) bump spec versions in kusama, polkadot and westend again (#2557) Guide update for availability distribution. (#2554) Whole subsystem test for new availability-distribution (#2552) Companion for `ExecuteBlock` changes in Substrate (#2548) Initialize telemetry earlier (#2549)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not a lot of code, and it can prevent stupid accidental mistakes.
Note that I haven't tested if this works, but it seems pretty straight-forward.